Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1108653002: Prevent a negative duration animation (Closed)

Created:
5 years, 8 months ago by gone
Modified:
5 years, 8 months ago
CC:
chromium-reviews, jdduke (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent a negative duration animation Haven't been able to repro this locally, but it's apparently possible for a calculation to return a negative value for an animation duration, resulting in a crash. BUG=481031 Committed: https://crrev.com/930d5e7d4878c1adf0d7b282b24324912778dc2a Cr-Commit-Position: refs/heads/master@{#326871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
gone
5 years, 8 months ago (2015-04-24 19:49:15 UTC) #2
aurimas (slooooooooow)
lgtm
5 years, 8 months ago (2015-04-24 20:40:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108653002/1
5 years, 8 months ago (2015-04-24 20:48:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 20:53:42 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 20:54:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/930d5e7d4878c1adf0d7b282b24324912778dc2a
Cr-Commit-Position: refs/heads/master@{#326871}

Powered by Google App Engine
This is Rietveld 408576698