chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java - Issue 1108653002: Prevent a negative duration animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java

Issue 1108653002: Prevent a negative duration animation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java

index 7bd6d878eb8e9efff4dbee1808354dc4aaeeac3a..373533560da5bd181e5df64f06a932c9fa8b7825 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java

@@ -653,7 +653,7 @@ public abstract class SwipableOverlayView extends ScrollView {

PropertyValuesHolder.ofFloat("translationY", getTranslationY(), y));

mCurrentAnimation = new AnimatorSet();

- mCurrentAnimation.setDuration(duration);

+ mCurrentAnimation.setDuration(Math.max(duration, 0));

mCurrentAnimation.playTogether(alphaAnimator, translationXAnimator, translationYAnimator);

mCurrentAnimation.addListener(mAnimatorListenerAdapter);

mCurrentAnimation.setInterpolator(mInterpolator);

« no previous file with comments | « no previous file | no next file » | no next file with comments »