Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs

Issue 11086056: Group libraries when linking with gcc (Closed) Base URL: http://nativeclient-sdk.googlecode.com/svn/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs
diff --git a/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs b/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs
index eb5c55cab3fd3803025f0857fed0e4776fa30306..768051e501fb8aa4a34cc26b42d35f66a75c243b 100644
--- a/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs
+++ b/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs
@@ -77,11 +77,16 @@ namespace NaCl.Build.CPPTasks
{
StringBuilder responseFileCmds = new StringBuilder(GCCUtilities.s_CommandLineLength);
+ // We want GCC to behave more like visual studio in term of library dependencies
+ // so we wrap all the inputs (libraries and object) into one group so they are
+ // searched iteratively.
+ responseFileCmds.Append("-Wl,--start-group ");
foreach (ITaskItem sourceFile in Sources)
{
responseFileCmds.Append(GCCUtilities.ConvertPathWindowsToPosix(sourceFile.GetMetadata("Identity")));
responseFileCmds.Append(" ");
}
+ responseFileCmds.Append("-Wl,--end-group ");
responseFileCmds.Append(m_XamlParser.Parse(Sources[0], false));
« no previous file with comments | « no previous file | visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698