Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs

Issue 11086056: Group libraries when linking with gcc (Closed) Base URL: http://nativeclient-sdk.googlecode.com/svn/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1  1 
2 using System; 2 using System;
3 using System.IO; 3 using System.IO;
4 using System.Resources; 4 using System.Resources;
5 using System.Reflection; 5 using System.Reflection;
6 using System.Text; 6 using System.Text;
7 using Microsoft.Build.Framework; 7 using Microsoft.Build.Framework;
8 using Microsoft.Build.CPPTasks; 8 using Microsoft.Build.CPPTasks;
9 9
10 10
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 70
71 protected override void LogEventsFromTextOutput(string singleLine, Messa geImportance messageImportance) 71 protected override void LogEventsFromTextOutput(string singleLine, Messa geImportance messageImportance)
72 { 72 {
73 base.LogEventsFromTextOutput(GCCUtilities.ConvertGCCOutput(singleLin e), messageImportance); 73 base.LogEventsFromTextOutput(GCCUtilities.ConvertGCCOutput(singleLin e), messageImportance);
74 } 74 }
75 75
76 protected override string GenerateResponseFileCommands() 76 protected override string GenerateResponseFileCommands()
77 { 77 {
78 StringBuilder responseFileCmds = new StringBuilder(GCCUtilities.s_Co mmandLineLength); 78 StringBuilder responseFileCmds = new StringBuilder(GCCUtilities.s_Co mmandLineLength);
79 79
80 // We want GCC to behave more like visual studio in term of library dependencies
81 // so we wrap all the inputs (libraries and object) into one group s o they are
82 // searched iteratively.
83 responseFileCmds.Append("-Wl,--start-group ");
80 foreach (ITaskItem sourceFile in Sources) 84 foreach (ITaskItem sourceFile in Sources)
81 { 85 {
82 responseFileCmds.Append(GCCUtilities.ConvertPathWindowsToPosix(s ourceFile.GetMetadata("Identity"))); 86 responseFileCmds.Append(GCCUtilities.ConvertPathWindowsToPosix(s ourceFile.GetMetadata("Identity")));
83 responseFileCmds.Append(" "); 87 responseFileCmds.Append(" ");
84 } 88 }
89 responseFileCmds.Append("-Wl,--end-group ");
85 90
86 responseFileCmds.Append(m_XamlParser.Parse(Sources[0], false)); 91 responseFileCmds.Append(m_XamlParser.Parse(Sources[0], false));
87 92
88 return responseFileCmds.ToString(); 93 return responseFileCmds.ToString();
89 } 94 }
90 95
91 public override bool Execute() 96 public override bool Execute()
92 { 97 {
93 bool returnResult = false; 98 bool returnResult = false;
94 99
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 { 191 {
187 return "GCC"; 192 return "GCC";
188 } 193 }
189 set 194 set
190 {} 195 {}
191 } 196 }
192 197
193 public string TrackerLogDirectory { get; set; } 198 public string TrackerLogDirectory { get; set; }
194 } 199 }
195 } 200 }
OLDNEW
« no previous file with comments | « no previous file | visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698