Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 11085063: Change DEPS to include cacheinvalidation code for Android. (Closed)

Created:
8 years, 2 months ago by nyquist
Modified:
8 years, 2 months ago
Reviewers:
szager
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Change DEPS to include cacheinvalidation code for Android. The Android build requires more of the cacheinvalidation library than other ports of Chrome. This changes to use the new full mirror of the SVN repo that points to trunk/src instead of trunk/src/google. To simplify transition and to clean up, the folder files is also removed from the path, and instead we checkout directly to cacheinvalidation/src. BUG=154703 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161656

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : Changed directory to cacheinvalidation/src and updated README.chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -66 lines) Patch
M DEPS View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/cacheinvalidation/README.chromium View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/cacheinvalidation/cacheinvalidation.gyp View 1 2 4 chunks +61 lines, -62 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nyquist
PTAL
8 years, 2 months ago (2012-10-11 01:55:13 UTC) #1
szager
lgtm
8 years, 2 months ago (2012-10-11 18:41:22 UTC) #2
szager
Let me know when you're ready to land this.
8 years, 2 months ago (2012-10-11 18:41:41 UTC) #3
nyquist
PTAL. Changed directory to cacheinvalidation/src and updated README.chromium and gyp targets.
8 years, 2 months ago (2012-10-12 01:24:24 UTC) #4
szager
lgtm
8 years, 2 months ago (2012-10-12 17:25:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/11085063/8001
8 years, 2 months ago (2012-10-12 17:27:56 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-12 21:35:18 UTC) #7
Change committed as 161656

Powered by Google App Engine
This is Rietveld 408576698