Allow custom context menus to be requested.

Allow custom context menus to be requested.

This allows external users to request that a render view show a context menu. This mostly exposes is a reaonsable interface the existing functionality, and removes the pepper-plugin-delegate-specific hacks.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161703

[brettw, 2012-10-08 05:20:05]

I was working on much more involved cleanup of the context menu stuff but I gave
up because it got too difficult to manage. So this just exposes the current
functionality in a more reasonable interface.

I think it's a lot cleaner for the two users, and will make my upcoming Pepper
refactor possible (since I'm removing the context menu stuff from the pepper
plugin delegate).

[jam, 2012-10-10 04:01:43]

lgtm

https://codereview.chromium.org/11083002/diff/1/content/public/renderer/conte...
File content/public/renderer/context_menu_client.h (right):

https://codereview.chromium.org/11083002/diff/1/content/public/renderer/conte...
content/public/renderer/context_menu_client.h:22: virtual void
OnCustomContextMenuAction(int request_id, unsigned action) = 0;
nit: since ContextMenu is in the interface name, it's a bit redundant to put it
in the callback names? i.e. just OnMenuAction and OnMenuClosed?

https://codereview.chromium.org/11083002/diff/1/content/public/renderer/rende...
File content/public/renderer/render_view.h (right):

https://codereview.chromium.org/11083002/diff/1/content/public/renderer/rende...
content/public/renderer/render_view.h:42: struct ContextMenuParams;
nit: put the struct after class RenderViewVistor

https://codereview.chromium.org/11083002/diff/1/content/renderer/render_view_...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/11083002/diff/1/content/renderer/render_view_...
content/renderer/render_view_impl.cc:6286: if (client) {
nit: why the null check? seems that if this is NULL it's a bug that a crash
would track down

[brettw, 2012-10-10 05:10:17]

https://codereview.chromium.org/11083002/diff/1/content/public/renderer/conte...
File content/public/renderer/context_menu_client.h (right):

https://codereview.chromium.org/11083002/diff/1/content/public/renderer/conte...
content/public/renderer/context_menu_client.h:22: virtual void
OnCustomContextMenuAction(int request_id, unsigned action) = 0;
I was originally thinking this would be implemented by some big classes where it
might get confusing, but it seems OK. Done.

https://codereview.chromium.org/11083002/diff/1/content/renderer/render_view_...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/11083002/diff/1/content/renderer/render_view_...
content/renderer/render_view_impl.cc:6286: if (client) {
Removed, this was leftover from a previous version of the code.