Allow custom context menus to be requested.

chrome/renderer/plugins/plugin_placeholder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/plugins/plugin_placeholder.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/json/string_escape.h"
 #include "base/string_piece.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/common/jstemplate_builder.h"
 #include "chrome/common/prerender_messages.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/renderer/chrome_content_renderer_client.h"
 #include "chrome/renderer/custom_menu_commands.h"
 #include "chrome/renderer/plugins/plugin_uma.h"
+#include "content/public/common/context_menu_params.h"
 #include "content/public/renderer/render_thread.h"
 #include "content/public/renderer/render_view.h"
 #include "grit/generated_resources.h"
 #include "grit/renderer_resources.h"
 #include "grit/webkit_strings.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebURLRequest.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebContextMenuData.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebElement.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
@@ skipping 191 matching lines @@
           GURL(kPluginPlaceholderDataURL))),
       title_(title),
       status_(new ChromeViewHostMsg_GetPluginInfo_Status),
       is_blocked_for_prerendering_(false),
       allow_loading_(false),
 #if defined(ENABLE_PLUGIN_INSTALLATION)
       placeholder_routing_id_(MSG_ROUTING_NONE),
 #endif
       hidden_(false),
       has_host_(false),
-      finished_loading_(false) {
+      finished_loading_(false),
+      context_menu_request_id_(0) {
   RenderThread::Get()->AddObserver(this);
 }
 
 PluginPlaceholder::~PluginPlaceholder() {
   RenderThread::Get()->RemoveObserver(this);
 #if defined(ENABLE_PLUGIN_INSTALLATION)
   if (placeholder_routing_id_ == MSG_ROUTING_NONE)
     return;
   RenderThread::Get()->RemoveRoute(placeholder_routing_id_);
   if (has_host_) {
@@ skipping 203 matching lines @@
   if (output.status.value == status_->value)
     return;
   chrome::ChromeContentRendererClient* client =
       static_cast<chrome::ChromeContentRendererClient*>(
           content::GetContentClient()->renderer());
   WebPlugin* new_plugin =
       client->CreatePlugin(render_view(), frame_, plugin_params_, output);
   ReplacePlugin(new_plugin);
 }
 
-void PluginPlaceholder::SetMessage(const string16& message) {
-  message_ = message;
-  if (finished_loading_)
-    UpdateMessage();
-}
-
-void PluginPlaceholder::UpdateMessage() {
-  std::string script = "window.setMessage(" +
-                       base::GetDoubleQuotedJson(message_) + ")";
-  plugin_->web_view()->mainFrame()->executeScript(
-      WebScriptSource(ASCIIToUTF16(script)));
-}
-
-void PluginPlaceholder::ContextMenuAction(unsigned id) {
+void PluginPlaceholder::OnMenuAction(int request_id, unsigned action) {
   if (g_last_active_menu != this)
     return;
-  switch (id) {
+  switch (action) {
     case chrome::MENU_COMMAND_PLUGIN_RUN: {
       RenderThread::Get()->RecordUserMetrics("Plugin_Load_Menu");
       LoadPlugin();
       break;
     }
     case chrome::MENU_COMMAND_PLUGIN_HIDE: {
       RenderThread::Get()->RecordUserMetrics("Plugin_Hide_Menu");
       HidePlugin();
       break;
     }
     default:
       NOTREACHED();
   }
 }
 
+void PluginPlaceholder::OnMenuClosed(int request_id) {
+  DCHECK(request_id == context_menu_request_id_);
+  context_menu_request_id_ = 0;
+}
+
+void PluginPlaceholder::SetMessage(const string16& message) {
+  message_ = message;
+  if (finished_loading_)
+    UpdateMessage();
+}
+
+void PluginPlaceholder::UpdateMessage() {
+  std::string script = "window.setMessage(" +
+                       base::GetDoubleQuotedJson(message_) + ")";
+  plugin_->web_view()->mainFrame()->executeScript(
+      WebScriptSource(ASCIIToUTF16(script)));
+}
+
 void PluginPlaceholder::ShowContextMenu(const WebMouseEvent& event) {
-  WebContextMenuData menu_data;
+  if (context_menu_request_id_)
+    return;  // Don't allow nested context menu requests.
 
-  size_t num_items = 3u;
-  if (!plugin_info_.path.value().empty())
-    num_items++;
+  content::ContextMenuParams params;
 
-  WebVector<WebMenuItemInfo> custom_items(num_items);
-
-  size_t i = 0;
   WebMenuItemInfo name_item;
   name_item.label = title_;
   name_item.hasTextDirectionOverride = false;
   name_item.textDirection =  WebKit::WebTextDirectionDefault;
-  custom_items[i++] = name_item;
+  params.custom_items.push_back(WebMenuItem(name_item));
 
   WebMenuItemInfo separator_item;
   separator_item.type = WebMenuItemInfo::Separator;
-  custom_items[i++] = separator_item;
+  params.custom_items.push_back(WebMenuItem(separator_item));
 
   if (!plugin_info_.path.value().empty()) {
     WebMenuItemInfo run_item;
     run_item.action = chrome::MENU_COMMAND_PLUGIN_RUN;
     // Disable this menu item if the plugin is blocked by policy.
     run_item.enabled = allow_loading_;
     run_item.label = WebString::fromUTF8(
         l10n_util::GetStringUTF8(IDS_CONTENT_CONTEXT_PLUGIN_RUN).c_str());
     run_item.hasTextDirectionOverride = false;
     run_item.textDirection =  WebKit::WebTextDirectionDefault;
-    custom_items[i++] = run_item;
+    params.custom_items.push_back(WebMenuItem(run_item));
   }
 
   WebMenuItemInfo hide_item;
   hide_item.action = chrome::MENU_COMMAND_PLUGIN_HIDE;
   hide_item.enabled = true;
   hide_item.label = WebString::fromUTF8(
       l10n_util::GetStringUTF8(IDS_CONTENT_CONTEXT_PLUGIN_HIDE).c_str());
   hide_item.hasTextDirectionOverride = false;
   hide_item.textDirection =  WebKit::WebTextDirectionDefault;
-  custom_items[i++] = hide_item;
+  params.custom_items.push_back(WebMenuItem(hide_item));
 
-  menu_data.customItems.swap(custom_items);
-  menu_data.mousePosition = WebPoint(event.windowX, event.windowY);
-  render_view()->ShowContextMenu(NULL, menu_data);
+  params.x = event.windowX;
+  params.y = event.windowY;
+
+  context_menu_request_id_ = render_view()->ShowContextMenu(this, params);
   g_last_active_menu = this;
 }
 
 void PluginPlaceholder::OnLoadBlockedPlugins(const std::string& identifier) {
   if (!identifier.empty() && identifier != identifier_)
     return;
 
   RenderThread::Get()->RecordUserMetrics("Plugin_Load_UI");
   LoadPlugin();
 }
@@ skipping 89 matching lines @@
 bool PluginPlaceholder::IsYouTubeURL(const GURL& url,
                                        const std::string& mime_type) {
   std::string host = url.host();
   bool is_youtube = EndsWith(host, "youtube.com", true) ||
       EndsWith(host, "youtube-nocookie.com", true);
 
   return is_youtube && IsValidYouTubeVideo(url.path()) &&
       LowerCaseEqualsASCII(mime_type, kFlashPluginSwfMimeType);
 }
 #endif