Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1108163002: Revert of De-proc Color32 (Closed)

Created:
5 years, 7 months ago by mtklein
Modified:
5 years, 7 months ago
Reviewers:
mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of De-proc Color32 (patchset #4 id:60001 of https://codereview.chromium.org/1104183004/) Reason for revert: MIPS Original issue's description: > De-proc Color32 > > Also strips SK_SUPPORT_LEGACY_COLOR32_MATH, > which is no longer needed. > > Seems handy to have SkTypes include the relevant intrinsics when > we know we've got them, but I'm not married to it. > > Locally this looks like a pointlessly small perf win, but I'm mostly > keen to get all the code together. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/376e9bc206b69d9190f38dfebb132a8769bbd72b TBR=reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/498856ebc6f22d7018071bd6696756d7cd077ab8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -99 lines) Patch
M include/core/SkBlitRow.h View 2 chunks +9 lines, -0 lines 0 comments Download
M include/core/SkTypes.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/core/SkBlitRow_D32.cpp View 2 chunks +21 lines, -84 lines 0 comments Download
M src/core/SkBlitter_ARGB32.cpp View 7 chunks +7 lines, -6 lines 0 comments Download
M src/core/SkCoreBlitters.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 2 chunks +9 lines, -3 lines 0 comments Download
M src/opts/SkBlitRow_opts_SSE2.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_SSE2.cpp View 1 chunk +65 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.cpp View 1 chunk +63 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_mips_dsp.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_none.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of De-proc Color32
5 years, 7 months ago (2015-04-27 21:16:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108163002/1
5 years, 7 months ago (2015-04-27 21:17:18 UTC) #2
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 21:17:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/498856ebc6f22d7018071bd6696756d7cd077ab8

Powered by Google App Engine
This is Rietveld 408576698