Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: runtime/vm/profiler.cc

Issue 1108123002: Enable profiler by default on Android, and reduce profiler sampling rate for An droid, ARM and MIPS. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/profiler.cc
diff --git a/runtime/vm/profiler.cc b/runtime/vm/profiler.cc
index e262c6084b40c2a9f00105713ddbe5acb205fcc3..c6359a907a56ca63e7989592569d1ee59b55d661 100644
--- a/runtime/vm/profiler.cc
+++ b/runtime/vm/profiler.cc
@@ -24,15 +24,16 @@
namespace dart {
-
-#if defined(TARGET_OS_ANDROID) || defined(HOST_ARCH_ARM64)
rmacnak 2015/04/27 21:06:18 Why host?
Cutch 2015/04/27 21:19:52 I think Zach had disabled this early in developmen
- DEFINE_FLAG(bool, profile, false, "Enable Sampling Profiler");
+DEFINE_FLAG(bool, profile, true, "Enable Sampling Profiler");
+DEFINE_FLAG(bool, trace_profiled_isolates, false, "Trace profiled isolates.");
+#if defined(TARGET_OS_ANDROID) || defined(TARGET_ARCH_ARM64) || \
+ defined(TARGET_ARCH_ARM) || defined(TARGET_ARCH_MIPS)
+ DEFINE_FLAG(int, profile_period, 10000,
+ "Time between profiler samples in microseconds. Minimum 50.");
#else
- DEFINE_FLAG(bool, profile, true, "Enable Sampling Profiler");
+ DEFINE_FLAG(int, profile_period, 1000,
+ "Time between profiler samples in microseconds. Minimum 50.");
#endif
-DEFINE_FLAG(bool, trace_profiled_isolates, false, "Trace profiled isolates.");
-DEFINE_FLAG(int, profile_period, 1000,
- "Time between profiler samples in microseconds. Minimum 50.");
DEFINE_FLAG(int, profile_depth, 8,
"Maximum number stack frames walked. Minimum 1. Maximum 255.");
#if defined(PROFILE_NATIVE_CODE) || defined(USING_SIMULATOR)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698