Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Side by Side Diff: runtime/vm/profiler.cc

Issue 1108123002: Enable profiler by default on Android, and reduce profiler sampling rate for An droid, ARM and MIPS. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/address_sanitizer.h" 5 #include "platform/address_sanitizer.h"
6 #include "platform/memory_sanitizer.h" 6 #include "platform/memory_sanitizer.h"
7 #include "platform/utils.h" 7 #include "platform/utils.h"
8 8
9 #include "vm/allocation.h" 9 #include "vm/allocation.h"
10 #include "vm/atomic.h" 10 #include "vm/atomic.h"
11 #include "vm/code_patcher.h" 11 #include "vm/code_patcher.h"
12 #include "vm/instructions.h" 12 #include "vm/instructions.h"
13 #include "vm/isolate.h" 13 #include "vm/isolate.h"
14 #include "vm/json_stream.h" 14 #include "vm/json_stream.h"
15 #include "vm/lockers.h" 15 #include "vm/lockers.h"
16 #include "vm/native_symbol.h" 16 #include "vm/native_symbol.h"
17 #include "vm/object.h" 17 #include "vm/object.h"
18 #include "vm/os.h" 18 #include "vm/os.h"
19 #include "vm/profiler.h" 19 #include "vm/profiler.h"
20 #include "vm/reusable_handles.h" 20 #include "vm/reusable_handles.h"
21 #include "vm/signal_handler.h" 21 #include "vm/signal_handler.h"
22 #include "vm/simulator.h" 22 #include "vm/simulator.h"
23 #include "vm/stack_frame.h" 23 #include "vm/stack_frame.h"
24 24
25 namespace dart { 25 namespace dart {
26 26
27 27 DEFINE_FLAG(bool, profile, true, "Enable Sampling Profiler");
28 #if defined(TARGET_OS_ANDROID) || defined(HOST_ARCH_ARM64) 28 DEFINE_FLAG(bool, trace_profiled_isolates, false, "Trace profiled isolates.");
rmacnak 2015/04/27 21:06:18 Why host?
Cutch 2015/04/27 21:19:52 I think Zach had disabled this early in developmen
29 DEFINE_FLAG(bool, profile, false, "Enable Sampling Profiler"); 29 #if defined(TARGET_OS_ANDROID) || defined(TARGET_ARCH_ARM64) || \
30 defined(TARGET_ARCH_ARM) || defined(TARGET_ARCH_MIPS)
31 DEFINE_FLAG(int, profile_period, 10000,
32 "Time between profiler samples in microseconds. Minimum 50.");
30 #else 33 #else
31 DEFINE_FLAG(bool, profile, true, "Enable Sampling Profiler"); 34 DEFINE_FLAG(int, profile_period, 1000,
35 "Time between profiler samples in microseconds. Minimum 50.");
32 #endif 36 #endif
33 DEFINE_FLAG(bool, trace_profiled_isolates, false, "Trace profiled isolates.");
34 DEFINE_FLAG(int, profile_period, 1000,
35 "Time between profiler samples in microseconds. Minimum 50.");
36 DEFINE_FLAG(int, profile_depth, 8, 37 DEFINE_FLAG(int, profile_depth, 8,
37 "Maximum number stack frames walked. Minimum 1. Maximum 255."); 38 "Maximum number stack frames walked. Minimum 1. Maximum 255.");
38 #if defined(PROFILE_NATIVE_CODE) || defined(USING_SIMULATOR) 39 #if defined(PROFILE_NATIVE_CODE) || defined(USING_SIMULATOR)
39 DEFINE_FLAG(bool, profile_vm, true, 40 DEFINE_FLAG(bool, profile_vm, true,
40 "Always collect native stack traces."); 41 "Always collect native stack traces.");
41 #else 42 #else
42 DEFINE_FLAG(bool, profile_vm, false, 43 DEFINE_FLAG(bool, profile_vm, false,
43 "Always collect native stack traces."); 44 "Always collect native stack traces.");
44 #endif 45 #endif
45 46
(...skipping 1026 matching lines...) Expand 10 before | Expand all | Expand 10 after
1072 state.fp, 1073 state.fp,
1073 sp); 1074 sp);
1074 stackWalker.walk(); 1075 stackWalker.walk();
1075 } else { 1076 } else {
1076 sample->set_vm_tag(VMTag::kEmbedderTagId); 1077 sample->set_vm_tag(VMTag::kEmbedderTagId);
1077 sample->SetAt(0, state.pc); 1078 sample->SetAt(0, state.pc);
1078 } 1079 }
1079 } 1080 }
1080 1081
1081 } // namespace dart 1082 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698