Chromium Code Reviews| Index: content/common/resource_messages.cc |
| diff --git a/content/common/resource_messages.cc b/content/common/resource_messages.cc |
| index 2f86ae2ecd750dd7e144a5a9ebd8ed55e986c748..4868b5be80954dd27d19726ce6a3926d39636972 100644 |
| --- a/content/common/resource_messages.cc |
| +++ b/content/common/resource_messages.cc |
| @@ -56,13 +56,18 @@ void ParamTraits<storage::DataElement>::Write(Message* m, const param_type& p) { |
| WriteParam(m, p.expected_modification_time()); |
| break; |
| } |
| - default: { |
| - DCHECK(p.type() == storage::DataElement::TYPE_BLOB); |
| + case storage::DataElement::TYPE_BLOB: { |
| WriteParam(m, p.blob_uuid()); |
| WriteParam(m, p.offset()); |
| WriteParam(m, p.length()); |
| break; |
| } |
| + case storage::DataElement::TYPE_DISK_CACHE_ENTRY: // Can't be sent via IPC. |
|
Tom Sepez
2015/06/15 15:53:06
nit: if one of the cases has { }, all of them shou
gavinp
2015/06/15 20:10:59
Done.
|
| + NOTREACHED(); |
| + break; |
| + case storage::DataElement::TYPE_UNKNOWN: |
|
Tom Sepez
2015/06/15 15:53:06
nit: Shouldn't this just be a default: case?
mmenke
2015/06/15 15:57:26
Without a default, adding a new case results in a
gavinp
2015/06/15 20:10:59
That's the reasoning I used here too.
|
| + NOTREACHED(); |
| + break; |
| } |
| } |