Create blobs from Disk Cache entries.

content/common/resource_messages.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/resource_messages.h"
 
 #include "net/base/load_timing_info.h"
 #include "net/http/http_response_headers.h"
 
 namespace IPC {
@@ skipping 38 matching lines @@
       WriteParam(m, p.expected_modification_time());
       break;
     }
     case storage::DataElement::TYPE_FILE_FILESYSTEM: {
       WriteParam(m, p.filesystem_url());
       WriteParam(m, p.offset());
       WriteParam(m, p.length());
       WriteParam(m, p.expected_modification_time());
       break;
     }
-    default: {
-      DCHECK(p.type() == storage::DataElement::TYPE_BLOB);
+    case storage::DataElement::TYPE_BLOB: {
       WriteParam(m, p.blob_uuid());
       WriteParam(m, p.offset());
       WriteParam(m, p.length());
       break;
     }
+    case storage::DataElement::TYPE_DISK_CACHE_ENTRY:  // Can't be sent via IPC.

[Tom Sepez, 2015/06/15 15:53:06]

nit: if one of the cases has { }, all of them should.

[gavinp, 2015/06/15 20:10:59]

Done.

+      NOTREACHED();
+      break;
+    case storage::DataElement::TYPE_UNKNOWN:

[Tom Sepez, 2015/06/15 15:53:06]

nit: Shouldn't this just be a default: case?

[mmenke, 2015/06/15 15:57:26]

Without a default, adding a new case results in a compile error.  With a
default, we get a runtime error instead, if we ever happen to reach this code
with the new value.  The compile error is much more robust.

[gavinp, 2015/06/15 20:10:59]

That's the reasoning I used here too.

+      NOTREACHED();
+      break;
   }
 }
 
 bool ParamTraits<storage::DataElement>::Read(const Message* m,
                                              base::PickleIterator* iter,
                                              param_type* r) {
   int type;
   if (!ReadParam(m, iter, &type))
     return false;
   switch (type) {
@@ skipping 217 matching lines @@
   (*r)->set_identifier(identifier);
   return true;
 }
 
 void ParamTraits<scoped_refptr<content::ResourceRequestBody> >::Log(
     const param_type& p, std::string* l) {
   l->append("<ResourceRequestBody>");
 }
 
 }  // namespace IPC