Create blobs from Disk Cache entries.

content/browser/loader/upload_data_stream_builder.cc

Index: content/browser/loader/upload_data_stream_builder.cc
diff --git a/content/browser/loader/upload_data_stream_builder.cc b/content/browser/loader/upload_data_stream_builder.cc
index c497c16c0a769ea50c20469ba1fc44e47708dc31..a117075b8ca552433aa5c9c5a5a29cfc653d4308 100644
--- a/content/browser/loader/upload_data_stream_builder.cc
+++ b/content/browser/loader/upload_data_stream_builder.cc
@@ -133,8 +133,9 @@ scoped_ptr<net::UploadDataStream> UploadDataStreamBuilder::Build(
       case ResourceRequestBody::Element::TYPE_BLOB:
         // Blob elements should be resolved beforehand.
         // TODO(dmurph): Create blob reader and store the snapshot in there.
-        NOTREACHED();
-        break;
+      case ResourceRequestBody::Element::TYPE_DISK_CACHE_ENTRY:
+        // Disk cache entries should not be uploaded, instead only requested

[jkarlin, 2015/05/29 14:59:41]

Prefer that you put back the "NOTREACHED()" in each case so that if you error
out you know which type it failed on.

[gavinp, 2015/05/29 18:06:07]

Done.

Now I understand why it was written the other way!

+        // from blink.
       case ResourceRequestBody::Element::TYPE_UNKNOWN:
         NOTREACHED();
         break;