Create blobs from Disk Cache entries.

content/browser/loader/upload_data_stream_builder.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/loader/upload_data_stream_builder.h"
 
 #include "base/logging.h"
 #include "content/browser/fileapi/upload_file_system_file_element_reader.h"
 #include "content/common/resource_request_body.h"
 #include "net/base/elements_upload_data_stream.h"
@@ skipping 115 matching lines @@
             new content::UploadFileSystemFileElementReader(
                 file_system_context,
                 element.filesystem_url(),
                 element.offset(),
                 element.length(),
                 element.expected_modification_time()));
         break;
       case ResourceRequestBody::Element::TYPE_BLOB:
         // Blob elements should be resolved beforehand.
         // TODO(dmurph): Create blob reader and store the snapshot in there.
-        NOTREACHED();
-        break;
+      case ResourceRequestBody::Element::TYPE_DISK_CACHE_ENTRY:
+        // Disk cache entries should not be uploaded, instead only requested

[jkarlin, 2015/05/29 14:59:41]

Prefer that you put back the "NOTREACHED()" in each case so that if you error
out you know which type it failed on.

[gavinp, 2015/05/29 18:06:07]

Done.

Now I understand why it was written the other way!

+        // from blink.
       case ResourceRequestBody::Element::TYPE_UNKNOWN:
         NOTREACHED();
         break;
     }
   }
 
   return make_scoped_ptr(
       new net::ElementsUploadDataStream(element_readers.Pass(),
                                         body->identifier()));
 }
 
 }  // namespace content