Create blobs from Disk Cache entries.

storage/browser/blob/blob_url_request_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "storage/browser/blob/blob_url_request_job.h"
 
 #include <algorithm>
 #include <limits>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/files/file_util_proxy.h"
 #include "base/format_macros.h"
 #include "base/message_loop/message_loop.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/trace_event/trace_event.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
+#include "net/disk_cache/disk_cache.h"
 #include "net/http/http_request_headers.h"
 #include "net/http/http_response_headers.h"
 #include "net/http/http_response_info.h"
 #include "net/http/http_util.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_error_job.h"
 #include "net/url_request/url_request_status.h"
 #include "storage/browser/fileapi/file_stream_reader.h"
 #include "storage/browser/fileapi/file_system_context.h"
@@ skipping 314 matching lines @@
   // If nothing to read for current item, advance to next item.
   if (bytes_to_read == 0) {
     AdvanceItem();
     return true;
   }
 
   // Do the reading.
   const BlobDataItem& item = *items.at(current_item_index_);
   if (item.type() == DataElement::TYPE_BYTES)
     return ReadBytesItem(item, bytes_to_read);
+  if (item.type() == DataElement::TYPE_DISK_CACHE_ENTRY)
+    return ReadDiskCacheEntryItem(item, bytes_to_read);
   if (!IsFileType(item.type())) {
     NOTREACHED();
     return false;
   }
   storage::FileStreamReader* const reader =
       GetFileStreamReader(current_item_index_);
   if (!reader) {
     NotifyFailure(net::ERR_FAILED);
     return false;
   }
@@ skipping 92 matching lines @@
 }
 
 void BlobURLRequestJob::DeleteCurrentFileReader() {
   IndexToReaderMap::iterator found = index_to_reader_.find(current_item_index_);
   if (found != index_to_reader_.end() && found->second) {
     delete found->second;
     index_to_reader_.erase(found);
   }
 }
 
+bool BlobURLRequestJob::ReadDiskCacheEntryItem(const BlobDataItem& item,
+                                               int bytes_to_read) {
+  DCHECK_GE(read_buf_->BytesRemaining(), bytes_to_read);
+
+  const int result = item.disk_cache_entry()->ReadData(
+      item.disk_cache_stream_index(), current_item_offset_, read_buf_.get(),
+      bytes_to_read, base::Bind(&BlobURLRequestJob::DidReadDiskCacheEntry,
+                                base::Unretained(this)));

[jkarlin, 2015/06/12 15:53:38]

Is base::Unretained safe here? Aren't jobs cleared when the renderer dies?  Same
question applies to ::ReadFileItem.

[gavinp, 2015/06/12 18:10:30]

But we're mid-read, so isn't the URLRequest::Delegate guaranteed to hold a
reference the entire time?

[jkarlin, 2015/06/12 19:17:52]

I don't know how blob URLRequests are routed. Do they go through the
ResourceDispatchHost? If so, when the renderer dies all of its URLRequests (and
delegates) die too and there won't be a |this| to run on.

mmenke will know

[mmenke, 2015/06/12 19:23:36]

Blob URL requests do indeed go through the RDH (Or at least some of them do -
there may be other paths for some, not sure).  An object actually owning the
underlying blob data is stapled to the corresponding URLRequestJob as UserData.

So I don't believe Unretained is safe here.  More generally, URLRequests may be
cancelled at any time, and URLRequestJobs are expected to support that.

[mmenke, 2015/06/12 19:38:44]

Sorry..scratch that.  The UserData stapling is for blob uploads, not sure about
blob downloads (Though both do go through the RDH)

+  DCHECK_LT(result, 0);

[jkarlin, 2015/06/12 15:53:38]

The header doesn't say that ReadData is async only. Should we really be
dchecking for an error here?

[gavinp, 2015/06/12 18:10:30]

True enough; and the memory cache is actually sync on this operation. Done.

+  if (result == net::ERR_IO_PENDING)
+    SetStatus(net::URLRequestStatus(net::URLRequestStatus::IO_PENDING, 0));
+  else
+    NotifyFailure(result);
+  return false;
+}
+
+void BlobURLRequestJob::DidReadDiskCacheEntry(int result) {
+  if (result <= 0) {

[jkarlin, 2015/06/12 15:53:38]

What if the item was 0 bytes? 

[gavinp, 2015/06/12 18:10:30]

Then we never called ReadDiskCacheEntryItem and there's no code path to here, so
something really bad has happened. Let's call that a failure.

See
https://codereview.chromium.org/1108083002/diff/590001/storage/browser/blob/b...

+    NotifyFailure(net::ERR_FAILED);
+    return;
+  }
+  SetStatus(net::URLRequestStatus());
+
+  AdvanceBytesRead(result);
+
+  if (!read_buf_->BytesRemaining()) {
+    int bytes_read = BytesReadCompleted();
+    NotifyReadComplete(bytes_read);
+    return;
+  }
+
+  int bytes_read = 0;
+  if (ReadLoop(&bytes_read))
+    NotifyReadComplete(bytes_read);
+}
+
 int BlobURLRequestJob::BytesReadCompleted() {
   int bytes_read = read_buf_->BytesConsumed();
   read_buf_ = NULL;
   return bytes_read;
 }
 
 int BlobURLRequestJob::ComputeBytesToRead() const {
   int64 current_item_length = item_length_list_[current_item_index_];
 
   int64 item_remaining = current_item_length - current_item_offset_;
@@ skipping 160 matching lines @@
 
     default:
       break;
   }
 
   NOTREACHED();
   return false;
 }
 
 }  // namespace storage