Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1108013003: Introduce --zap-cpp-pointers (off by default)

Created:
5 years, 7 months ago by Jakob Kummerow
Modified:
3 years, 7 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce --zap-cpp-pointers (off by default) Zaps heap pointers in C++ stack frames on every allocation.

Patch Set 1 #

Patch Set 2 : hook into IncrementalMarking::Step too #

Patch Set 3 : 2017 edition #

Patch Set 4 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -25 lines) Patch
M src/api-arguments.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/execution.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M src/execution.cc View 1 2 2 chunks +10 lines, -2 lines 0 comments Download
M src/factory.cc View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/frames.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/frames.cc View 1 2 3 1 chunk +162 lines, -0 lines 0 comments Download
M src/heap/heap-inl.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M src/heap/spaces.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/property-descriptor.cc View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M src/regexp/regexp-macro-assembler.cc View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M src/type-info.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/type-info.cc View 1 2 1 chunk +11 lines, -8 lines 0 comments Download
M test/cctest/test-debug.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
Jakob Kummerow
5 years, 7 months ago (2015-04-29 11:49:26 UTC) #2
For discussion. In my local testing (V8 test suite; loading a handful of
websites in Chrome), this didn't flush out any issues. Do we want to land it
anyway, for the benefit of future/broader coverage?

Powered by Google App Engine
This is Rietveld 408576698