Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: src/heap/heap-inl.h

Issue 1108013003: Introduce --zap-cpp-pointers (off by default) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fixes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/frames.cc ('k') | src/heap/spaces.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap-inl.h
diff --git a/src/heap/heap-inl.h b/src/heap/heap-inl.h
index 1ed19107f01b35b0e9549e174fa3a985c3d29622..6594c33bd19d558ef17a7dbf598b10fa94d05672 100644
--- a/src/heap/heap-inl.h
+++ b/src/heap/heap-inl.h
@@ -305,6 +305,13 @@ AllocationResult Heap::AllocateRaw(int size_in_bytes, AllocationSpace space,
}
isolate_->counters()->objs_since_last_full()->Increment();
isolate_->counters()->objs_since_last_young()->Increment();
+
+// TODO(jkummerow): Handlify more of heap.cc to maintain the rule that
+// "there are no raw pointers anywhere on the stack when an allocation
+// is happening", and then remove the ZapHeapPointersInCppFrames() call
+// from CALL_HEAP_FUNCTION and instead enable it here.
+
+// if (FLAG_zap_cpp_pointers) ZapHeapPointersInCppFrames(isolate_);
#endif
bool large_object = size_in_bytes > kMaxRegularHeapObjectSize;
« no previous file with comments | « src/frames.cc ('k') | src/heap/spaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698