Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1231)

Unified Diff: ios/chrome/browser/experimental_flags.mm

Issue 1107963002: Add MemoryWedge to ios/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Synced Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/experimental_flags.mm
diff --git a/ios/chrome/browser/experimental_flags.mm b/ios/chrome/browser/experimental_flags.mm
index a1ab78ee02c8030a51de69c2f953783f9aafb398..e224a74d1ebfaa10d0173a633045e0685e6b4cd0 100644
--- a/ios/chrome/browser/experimental_flags.mm
+++ b/ios/chrome/browser/experimental_flags.mm
@@ -7,7 +7,12 @@
#include "ios/chrome/browser/experimental_flags.h"
+#include <string>
+
#include "base/command_line.h"
+#include "base/metrics/field_trial.h"
+#include "base/strings/string_number_conversions.h"
+#include "components/variations/variations_associated_data.h"
#include "ios/chrome/browser/chrome_switches.h"
namespace experimental_flags {
@@ -17,4 +22,24 @@ bool IsOpenFromClipboardEnabled() {
return command_line->HasSwitch(switches::kEnableIOSOpenFromClipboard);
}
+unsigned MemoryWedgeSizeInMB() {
+ std::string wedge_size_string;
+
+ // Get the size from the Experimental setting.
+ base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
+ wedge_size_string =
+ command_line->GetSwitchValueASCII(switches::kIOSMemoryWedgeSize);
+
+ // Otherwise, get from Finch.
+ if (wedge_size_string.empty()) {
+ wedge_size_string =
+ variations::GetVariationParamValue("MemoryWedge", "wedge_size");
+ }
+
+ // Parse the value.
+ unsigned wedge_size_in_mb = 0;
+ base::StringToUint(wedge_size_string, &wedge_size_in_mb);
Alexei Svitkine (slow) 2015/04/28 16:52:58 Should this check return value?
lpromero 2015/04/28 18:12:46 Discussed over IM. Will check the bool returned an
+ return wedge_size_in_mb;
+}
+
} // namespace experimental_flags

Powered by Google App Engine
This is Rietveld 408576698