Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Side by Side Diff: ios/chrome/browser/experimental_flags.mm

Issue 1107963002: Add MemoryWedge to ios/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Synced Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file can be empty. Its purpose is to contain the relatively short lived 5 // This file can be empty. Its purpose is to contain the relatively short lived
6 // definitions required for experimental flags. 6 // definitions required for experimental flags.
7 7
8 #include "ios/chrome/browser/experimental_flags.h" 8 #include "ios/chrome/browser/experimental_flags.h"
9 9
10 #include <string>
11
10 #include "base/command_line.h" 12 #include "base/command_line.h"
13 #include "base/metrics/field_trial.h"
14 #include "base/strings/string_number_conversions.h"
15 #include "components/variations/variations_associated_data.h"
11 #include "ios/chrome/browser/chrome_switches.h" 16 #include "ios/chrome/browser/chrome_switches.h"
12 17
13 namespace experimental_flags { 18 namespace experimental_flags {
14 19
15 bool IsOpenFromClipboardEnabled() { 20 bool IsOpenFromClipboardEnabled() {
16 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); 21 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
17 return command_line->HasSwitch(switches::kEnableIOSOpenFromClipboard); 22 return command_line->HasSwitch(switches::kEnableIOSOpenFromClipboard);
18 } 23 }
19 24
25 unsigned MemoryWedgeSizeInMB() {
26 std::string wedge_size_string;
27
28 // Get the size from the Experimental setting.
29 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
30 wedge_size_string =
31 command_line->GetSwitchValueASCII(switches::kIOSMemoryWedgeSize);
32
33 // Otherwise, get from Finch.
34 if (wedge_size_string.empty()) {
35 wedge_size_string =
36 variations::GetVariationParamValue("MemoryWedge", "wedge_size");
37 }
38
39 // Parse the value.
40 unsigned wedge_size_in_mb = 0;
41 base::StringToUint(wedge_size_string, &wedge_size_in_mb);
Alexei Svitkine (slow) 2015/04/28 16:52:58 Should this check return value?
lpromero 2015/04/28 18:12:46 Discussed over IM. Will check the bool returned an
42 return wedge_size_in_mb;
43 }
44
20 } // namespace experimental_flags 45 } // namespace experimental_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698