Replace const by value return values to const by ref in net/socket/tcp_listen_socket_unittest.h

Replace const by value return values to const by ref in net/socket/tcp_listen_socket_unittest.h

This CL turns const by value return values into const by ref

Replacing const value by a const ref when a member variable is safe, because
the member variable will live at least as long as the temporary object returned
now. It can also be more efficient, because returning a ref can spare copying.

BUG=393155
Committed: https://crrev.com/2cfa7f9a3496959dcf3785514d1f8fc89d471fb4
Cr-Commit-Position: refs/heads/master@{#327680}

[b.siddharth, 2015-04-27 13:16:16]

b.siddharth@samsung.com changed reviewers:
+ gavinp@chromium.org, mattm@chromium.org

[b.siddharth, 2015-04-27 13:16:16]

Please have a look, Thanks.

[mattm, 2015-04-27 21:36:47]

I think the commit description could be simplified/clarified. The summary line
is pretty vague even though only one specific type of change is being made.

Also "in socket" is ambiguous. You could say "in net/socket/", or in this case
since you're only touching a single file I'd just say "in
tcp_listen_socket_unittest.h".

[b.siddharth, 2015-04-28 07:54:48]

On 2015/04/27 21:36:47, mattm wrote:
> I think the commit description could be simplified/clarified. The summary line
> is pretty vague even though only one specific type of change is being made.
> 
> Also "in socket" is ambiguous. You could say "in net/socket/", or in this case
> since you're only touching a single file I'd just say "in
> tcp_listen_socket_unittest.h".

Changed the title and description.
Please have a look, Thanks.

[b.siddharth, 2015-04-29 10:25:16]

b.siddharth@samsung.com changed reviewers:
+ eroman@chromium.org

[b.siddharth, 2015-04-29 10:25:54]

All the changes have been done, Please review. Thanks.

[b.siddharth, 2015-04-29 18:37:14]

@mattm : Updated the descrption. Please have a look again.
Thanks.

[mattm, 2015-04-29 19:34:38]

lgtm

[b.siddharth, 2015-04-29 20:32:47]

The CQ bit was checked by b.siddharth@samsung.com

[commit-bot: I haz the power, 2015-04-29 20:34:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1107943002/1

[commit-bot: I haz the power, 2015-04-29 20:43:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-29 20:43:51]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[b.siddharth, 2015-04-30 07:15:10]

The CQ bit was checked by b.siddharth@samsung.com

[b.siddharth, 2015-04-30 07:15:10]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/1107943002/#ps20001
(title: "Fixed the trybot issue.")

[commit-bot: I haz the power, 2015-04-30 07:15:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1107943002/20001

[commit-bot: I haz the power, 2015-04-30 07:24:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-30 07:24:28]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[b.siddharth, 2015-04-30 07:36:10]

The CQ bit was checked by b.siddharth@samsung.com

[b.siddharth, 2015-04-30 07:36:10]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/1107943002/#ps40001
(title: "Added AUTHOR file.")

[commit-bot: I haz the power, 2015-04-30 07:36:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1107943002/40001

[commit-bot: I haz the power, 2015-04-30 08:04:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-30 08:05:38]

Patchset 3 (id:??) landed as
https://crrev.com/2cfa7f9a3496959dcf3785514d1f8fc89d471fb4
Cr-Commit-Position: refs/heads/master@{#327680}

[earlenemccullough22, 2015-05-04 19:42:59]

earlenemccullough22@gmail.com changed reviewers:
+ earlenemccullough22@gmail.com

[earlenemccullough22, 2015-05-04 19:43:03]

lgtm