net/socket/tcp_listen_socket_unittest.h - Issue 1107943002: Replace const by value return values to const by ref in net/socket/tcp_listen_socket_unittest.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/tcp_listen_socket_unittest.h

Issue 1107943002: Replace const by value return values to const by ref in net/socket/tcp_listen_socket_unittest.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added AUTHOR file. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/tcp_listen_socket_unittest.h

diff --git a/net/socket/tcp_listen_socket_unittest.h b/net/socket/tcp_listen_socket_unittest.h

index 984442afdc04b62fe40483c09581c89b0ad13c18..cd19a1caefc1914f29517634febec16ca2bcbbdd 100644

--- a/net/socket/tcp_listen_socket_unittest.h

+++ b/net/socket/tcp_listen_socket_unittest.h

@@ -48,7 +48,7 @@ class TCPListenSocketTestAction {

: action_(action),

data_(data) {}

- const std::string data() const { return data_; }

+ const std::string& data() const { return data_; }

ActionType type() const { return action_; }

private:

« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »