Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3290)

Unified Diff: chrome/browser/chromeos/login/existing_user_controller.cc

Issue 1107873002: Test BlockingLoginTestInstance with enabled webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/policy/blocking_login_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/existing_user_controller.cc
diff --git a/chrome/browser/chromeos/login/existing_user_controller.cc b/chrome/browser/chromeos/login/existing_user_controller.cc
index 4cb375342cb0207393f597bf3c97b342113ad174..bca0545369b63e5e497eefaf0a2510496115d899 100644
--- a/chrome/browser/chromeos/login/existing_user_controller.cc
+++ b/chrome/browser/chromeos/login/existing_user_controller.cc
@@ -945,16 +945,22 @@ void ExistingUserController::ShowError(int error_id,
const std::string& details) {
VLOG(1) << details;
HelpAppLauncher::HelpTopic help_topic_id;
- switch (login_performer_->error().state()) {
- case GoogleServiceAuthError::ACCOUNT_DISABLED:
- help_topic_id = HelpAppLauncher::HELP_ACCOUNT_DISABLED;
- break;
- case GoogleServiceAuthError::HOSTED_NOT_ALLOWED:
- help_topic_id = HelpAppLauncher::HELP_HOSTED_ACCOUNT;
- break;
- default:
- help_topic_id = HelpAppLauncher::HELP_CANT_ACCESS_ACCOUNT;
- break;
+ if (login_performer_) {
+ switch (login_performer_->error().state()) {
+ case GoogleServiceAuthError::ACCOUNT_DISABLED:
+ help_topic_id = HelpAppLauncher::HELP_ACCOUNT_DISABLED;
+ break;
+ case GoogleServiceAuthError::HOSTED_NOT_ALLOWED:
+ help_topic_id = HelpAppLauncher::HELP_HOSTED_ACCOUNT;
+ break;
+ default:
+ help_topic_id = HelpAppLauncher::HELP_CANT_ACCESS_ACCOUNT;
+ break;
+ }
+ } else {
+ // login_performer_ might be null if error happened during OAuth2 token
Nikita (slow) 2015/04/27 13:05:49 nit: update comment login_performer_ most likely w
Dmitry Polukhin 2015/04/27 14:51:58 Done.
+ // fetch, in this case show generic error.
+ help_topic_id = HelpAppLauncher::HELP_CANT_ACCESS_ACCOUNT;
}
if (error_id == IDS_LOGIN_ERROR_AUTHENTICATING) {
@@ -1217,7 +1223,7 @@ void ExistingUserController::OnOAuth2TokensFetched(
const UserContext& user_context) {
if (!success) {
LOG(ERROR) << "OAuth2 token fetch failed.";
- OnAuthFailure(AuthFailure(AuthFailure::NETWORK_AUTH_FAILED));
+ OnAuthFailure(AuthFailure(AuthFailure::FAILED_TO_INITIALIZE_TOKEN));
return;
}
PerformLogin(user_context, LoginPerformer::AUTH_MODE_EXTENSION);
« no previous file with comments | « no previous file | chrome/browser/chromeos/policy/blocking_login_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698