Test BlockingLoginTestInstance with enabled webview

chrome/browser/chromeos/login/existing_user_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/existing_user_controller.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 927 matching lines @@
 }
 
 gfx::NativeWindow ExistingUserController::GetNativeWindow() const {
   return host_->GetNativeWindow();
 }
 
 void ExistingUserController::ShowError(int error_id,
                                        const std::string& details) {
   VLOG(1) << details;
   HelpAppLauncher::HelpTopic help_topic_id;
-  switch (login_performer_->error().state()) {
-    case GoogleServiceAuthError::ACCOUNT_DISABLED:
-      help_topic_id = HelpAppLauncher::HELP_ACCOUNT_DISABLED;
-      break;
-    case GoogleServiceAuthError::HOSTED_NOT_ALLOWED:
-      help_topic_id = HelpAppLauncher::HELP_HOSTED_ACCOUNT;
-      break;
-    default:
-      help_topic_id = HelpAppLauncher::HELP_CANT_ACCESS_ACCOUNT;
-      break;
+  if (login_performer_) {
+    switch (login_performer_->error().state()) {
+      case GoogleServiceAuthError::ACCOUNT_DISABLED:
+        help_topic_id = HelpAppLauncher::HELP_ACCOUNT_DISABLED;
+        break;
+      case GoogleServiceAuthError::HOSTED_NOT_ALLOWED:
+        help_topic_id = HelpAppLauncher::HELP_HOSTED_ACCOUNT;
+        break;
+      default:
+        help_topic_id = HelpAppLauncher::HELP_CANT_ACCESS_ACCOUNT;
+        break;
+    }
+  } else {
+    // login_performer_ might be null if error happened during OAuth2 token

[Nikita (slow), 2015/04/27 13:05:49]

nit: update comment
login_performer_ most likely will be null (created only in CompleteLogin)

[Dmitry Polukhin, 2015/04/27 14:51:58]

Done.

+    // fetch, in this case show generic error.
+    help_topic_id = HelpAppLauncher::HELP_CANT_ACCESS_ACCOUNT;
   }
 
   if (error_id == IDS_LOGIN_ERROR_AUTHENTICATING) {
     if (num_login_attempts_ > 1) {
       const user_manager::User* user =
           user_manager::UserManager::Get()->FindUser(
               last_login_attempt_username_);
       if (user && (user->GetType() == user_manager::USER_TYPE_SUPERVISED))
         error_id = IDS_LOGIN_ERROR_AUTHENTICATING_2ND_TIME_SUPERVISED;
     }
@@ skipping 242 matching lines @@
           bootstrap_user_context_initializer_->random_key_used()));
 
   PerformLogin(user_context, LoginPerformer::AUTH_MODE_EXTENSION);
 }
 
 void ExistingUserController::OnOAuth2TokensFetched(
     bool success,
     const UserContext& user_context) {
   if (!success) {
     LOG(ERROR) << "OAuth2 token fetch failed.";
-    OnAuthFailure(AuthFailure(AuthFailure::NETWORK_AUTH_FAILED));
+    OnAuthFailure(AuthFailure(AuthFailure::FAILED_TO_INITIALIZE_TOKEN));
     return;
   }
   PerformLogin(user_context, LoginPerformer::AUTH_MODE_EXTENSION);
 }
 
 }  // namespace chromeos