Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: sky/engine/core/script/dart_service_isolate/server.dart

Issue 1107803002: Add Observatory to sky dart_controller (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/script/dart_service_isolate/server.dart
diff --git a/mojo/dart/embedder/vmservice/server.dart b/sky/engine/core/script/dart_service_isolate/server.dart
similarity index 95%
copy from mojo/dart/embedder/vmservice/server.dart
copy to sky/engine/core/script/dart_service_isolate/server.dart
index 188b532399d0241f7aa5b5fb4321dfb58a501b81..4e069f97edcdb419f0b2ca6b4bbad737262242ff 100644
--- a/mojo/dart/embedder/vmservice/server.dart
+++ b/sky/engine/core/script/dart_service_isolate/server.dart
@@ -35,17 +35,9 @@ class WebSocketClient extends Client {
}
}
- post(var serial, dynamic result) {
+ post(dynamic result) {
try {
- if (serial == null && result is! String) {
- socket.add(result);
- } else {
- Map map = {
- 'id': serial,
- 'result': result
- };
- socket.add(JSON.encode(map));
- }
+ socket.add(result);
} catch (_) {
print("Ignoring error posting over WebSocket.");
}
@@ -67,7 +59,7 @@ class HttpRequestClient extends Client {
HttpRequestClient(this.request, VMService service) : super(service);
- post(var serial, String result) {
+ post(String result) {
request.response..headers.contentType = jsonContentType
..write(result)
..close();

Powered by Google App Engine
This is Rietveld 408576698