Add Observatory to sky dart_controller

sky/engine/bindings/BUILD.gn

Index: sky/engine/bindings/BUILD.gn
diff --git a/sky/engine/bindings/BUILD.gn b/sky/engine/bindings/BUILD.gn
index 0e8edf2363ecfa6347a482d54aa6f1a519f830db..b7a6e171f3adfbefcba6070d2192b6c396c0d64d 100644
--- a/sky/engine/bindings/BUILD.gn
+++ b/sky/engine/bindings/BUILD.gn
@@ -7,6 +7,49 @@ import("//sky/engine/core/core.gni")
 
 source_set("bindings") {
   sources = [
+    "//dart/runtime/bin/dartutils.cc",
+    "//dart/runtime/bin/dartutils.h",
+    "//dart/runtime/bin/directory.cc",
+    "//dart/runtime/bin/directory.h",
+    "//dart/runtime/bin/directory_android.cc",
+    "//dart/runtime/bin/eventhandler.cc",
+    "//dart/runtime/bin/eventhandler_android.cc",
+    "//dart/runtime/bin/fdutils.h",
+    "//dart/runtime/bin/fdutils_android.cc",
+    "//dart/runtime/bin/file.cc",
+    "//dart/runtime/bin/file.h",
+    "//dart/runtime/bin/file_android.cc",
+    "//dart/runtime/bin/file_system_watcher.cc",
+    "//dart/runtime/bin/file_system_watcher.h",
+    "//dart/runtime/bin/file_system_watcher_android.cc",
+    "//dart/runtime/bin/filter.cc",
+    "//dart/runtime/bin/filter.h",
+    "//dart/runtime/bin/io_buffer.cc",
+    "//dart/runtime/bin/io_buffer.h",
+    "//dart/runtime/bin/io_natives.cc",
+    "//dart/runtime/bin/io_natives.h",
+    "//dart/runtime/bin/io_service.cc",
+    "//dart/runtime/bin/io_service.h",
+    "//dart/runtime/bin/log.h",
+    "//dart/runtime/bin/log_android.cc",
+    "//dart/runtime/bin/platform.cc",
+    "//dart/runtime/bin/platform.h",
+    "//dart/runtime/bin/platform_android.cc",
+    "//dart/runtime/bin/process.cc",
+    "//dart/runtime/bin/process.h",
+    "//dart/runtime/bin/process_android.cc",
+    "//dart/runtime/bin/secure_socket_unsupported.cc",
+    "//dart/runtime/bin/socket.cc",
+    "//dart/runtime/bin/socket.h",
+    "//dart/runtime/bin/socket_android.cc",
+    "//dart/runtime/bin/stdio.cc",
+    "//dart/runtime/bin/stdio.h",
+    "//dart/runtime/bin/stdio_android.cc",
+    "//dart/runtime/bin/thread.h",
+    "//dart/runtime/bin/thread_android.cc",
+    "//dart/runtime/bin/thread_android.h",
+    "//dart/runtime/bin/utils.h",
+    "//dart/runtime/bin/utils_android.cc",

[abarth-chromium, 2015/04/26 21:51:35]

Will this list of files be a burden to maintain?  Should we have a GN variable
for this list stored in the Dart repo?  Can we encapsulate these files in a GN
source_set?

[Cutch, 2015/04/27 14:59:10]

It shouldn't be a burden to maintain (the list of sources has been stable for a
long time now). Regardless, I've added a new source set which is built by
applying a custom filter to two .gypi files in the Dart tree.

     "builtin.cc",
     "builtin.h",
     "builtin_natives.cc",
@@ -30,6 +73,9 @@ source_set("bindings") {
     "scheduled_action.cc",
     "scheduled_action.h",
   ]
+
+  defines = [ "DART_IO_SECURE_SOCKET_DISABLED" ]
+
   deps = [
     "//base",
     "//dart/runtime/bin:libdart_withcore",
@@ -44,6 +90,8 @@ source_set("bindings") {
   include_dirs = [
     "..",
     "$root_build_dir",
+    rebase_path("//dart/runtime"),
+    rebase_path("//third_party"),
   ]
 }