Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1107793002: Oilpan: have DOMException be on the heap by default. (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, shans, vivekg_samsung, johnme+watch_chromium.org, eae+blinkwatch, eric.carlson_apple.com, vivekg, scheib+watch_chromium.org, apavlov+blink_chromium.org, Steve Block, rwlbuis, jsbell+serviceworker_chromium.org, arv+blink, blink-reviews-dom_chromium.org, blink-reviews-css, tzik, Timothy Loh, dstockwell, dglazkov+blink, blink-reviews-bindings_chromium.org, Eric Willigers, philipj_slow, rjwright, mvanouwerkerk+watch_chromium.org, sof, nhiroki, feature-media-reviews_chromium.org, darktears, michaeln, blink-reviews-animation_chromium.org, serviceworker-reviews, falken, Mike Lawther (Google), ed+blinkwatch_opera.com, kinuko+serviceworker, Inactive, horo+watch_chromium.org, peter+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: have DOMException be on the heap by default. R=haraken BUG=479467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -73 lines) Patch
M Source/bindings/core/v8/ScriptPromise.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptPromise.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8ThrowException.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationPlayer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/FontFace.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/FontFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMException.h View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/dom/DOMException.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/DOMException.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/streams/ReadableStream.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/streams/ReadableStream.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/streams/ReadableStreamImpl.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/streams/ReadableStreamReader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/background_sync/SyncError.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/background_sync/SyncError.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/bluetooth/BluetoothError.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/bluetooth/BluetoothError.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/cachestorage/Cache.h View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/cachestorage/Cache.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/cachestorage/CacheStorage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.h View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/fetch/Body.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/fetch/Body.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/fetch/BodyStreamBuffer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/fetch/BodyStreamBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/fetch/BodyStreamBufferTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/fetch/ResponseTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/geofencing/GeofencingError.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/geofencing/GeofencingError.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/presentation/PresentationError.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/presentation/PresentationError.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/push_messaging/PushError.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/push_messaging/PushError.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClients.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerError.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerError.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/vr/NavigatorVRDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VRHardwareUnitCollection.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
sof
please take a look.
5 years, 8 months ago (2015-04-26 06:21:23 UTC) #2
haraken
LGTM
5 years, 8 months ago (2015-04-26 09:01:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107793002/1
5 years, 8 months ago (2015-04-26 14:51:23 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-26 14:54:32 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194453

Powered by Google App Engine
This is Rietveld 408576698