Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: Source/core/css/FontFace.h

Issue 1107793002: Oilpan: have DOMException be on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/AnimationPlayer.h ('k') | Source/core/css/FontFace.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/FontFace.h
diff --git a/Source/core/css/FontFace.h b/Source/core/css/FontFace.h
index fa1f190994ecd0e3db01d096b83cfb39256b8646..cb270c58a8edc10cf14e190f360d771aa0d1f74d 100644
--- a/Source/core/css/FontFace.h
+++ b/Source/core/css/FontFace.h
@@ -91,8 +91,8 @@ public:
LoadStatus loadStatus() const { return m_status; }
void setLoadStatus(LoadStatus);
- void setError(PassRefPtrWillBeRawPtr<DOMException> = nullptr);
- DOMException* error() const { return m_error.get(); }
+ void setError(DOMException* = nullptr);
+ DOMException* error() const { return m_error; }
FontTraits traits() const;
CSSFontFace* cssFontFace() { return m_cssFontFace.get(); }
@@ -129,7 +129,7 @@ private:
void loadInternal(ExecutionContext*);
ScriptPromise fontStatusPromise(ScriptState*);
- typedef ScriptPromiseProperty<RawPtrWillBeMember<FontFace>, RawPtrWillBeMember<FontFace>, RefPtrWillBeMember<DOMException>> LoadedProperty;
+ typedef ScriptPromiseProperty<RawPtrWillBeMember<FontFace>, RawPtrWillBeMember<FontFace>, Member<DOMException>> LoadedProperty;
AtomicString m_family;
RefPtrWillBeMember<CSSValue> m_src;
@@ -140,7 +140,7 @@ private:
RefPtrWillBeMember<CSSValue> m_variant;
RefPtrWillBeMember<CSSValue> m_featureSettings;
LoadStatus m_status;
- RefPtrWillBeMember<DOMException> m_error;
+ PersistentWillBeMember<DOMException> m_error;
PersistentWillBeMember<LoadedProperty> m_loadedProperty;
OwnPtrWillBeMember<CSSFontFace> m_cssFontFace;
« no previous file with comments | « Source/core/animation/AnimationPlayer.h ('k') | Source/core/css/FontFace.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698