base: Minor MemoryDumpProvider cleanup.

base: Minor MemoryDumpProvider cleanup.

Leave it up to the implementation of this interface to determine
if assignment and copy should be disallowed.

BUG=

Committed: https://crrev.com/6f2fa9715bfc79d559f39077b34b0b71761ecb54
Cr-Commit-Position: refs/heads/master@{#327492}

[reveman, 2015-04-28 21:04:04]

reveman@chromium.org changed reviewers:
+ primiano@chromium.org

[Primiano Tucci (use gerrit), 2015-04-28 21:09:50]

Uhm, the thing I am trying to avoid here is that you register a MDP and then
get's (accidentally or not) copied over but the MDM still refers to the old
object.

On the other side, I can see some points in having the impl of the MDP be
copiable, provided that it registers and unregisters at the right time.

In conclusion: LGTM if there is a case for this, and the DISALLOW_ macro would
make the embedder design hander. If not, I'd probably leave it.

[reveman, 2015-04-29 02:00:28]

On 2015/04/28 at 21:09:50, primiano wrote:
> Uhm, the thing I am trying to avoid here is that you register a MDP and then
get's (accidentally or not) copied over but the MDM still refers to the old
object.
> 
> On the other side, I can see some points in having the impl of the MDP be
copiable, provided that it registers and unregisters at the right time.
> 
> In conclusion: LGTM if there is a case for this, and the DISALLOW_ macro would
make the embedder design hander. If not, I'd probably leave it.

Left DISALLOW_COPY_AND_ASSIGN protected instead. This prevents slicing but
allows an implementation to support copy and assign if it wants to.

I never looked at this in detail until now. Chromium typically omits this for
abstract classes but I think that's wrong and we should have a protected
DISALLOW_COPY_AND_ASSIGN for all abstract classes.

[reveman, 2015-04-29 02:01:38]

The CQ bit was checked by reveman@chromium.org

[reveman, 2015-04-29 02:01:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/1107403003/#ps20001
(title: "instead make DISALLOW_COPY_AND_ASSIGN protected")

[commit-bot: I haz the power, 2015-04-29 02:03:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1107403003/20001

[commit-bot: I haz the power, 2015-04-29 02:12:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-29 02:12:49]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Primiano Tucci (use gerrit), 2015-04-29 07:50:55]

> Left DISALLOW_COPY_AND_ASSIGN protected instead. This prevents slicing but
> allows an implementation to support copy and assign if it wants to.
> 
> I never looked at this in detail until now. Chromium typically omits this for
> abstract classes but I think that's wrong and we should have a protected
> DISALLOW_COPY_AND_ASSIGN for all abstract classes.
+1

Ah, turns out that if you have DISALLOW_COPY_AND_ASSIGN, you need an explicit
default ctor ;-)

[reveman, 2015-04-29 13:25:13]

The CQ bit was checked by reveman@chromium.org

[reveman, 2015-04-29 13:25:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/1107403003/#ps40001
(title: "restore explicit default ctor")

[commit-bot: I haz the power, 2015-04-29 13:25:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1107403003/40001

[commit-bot: I haz the power, 2015-04-29 15:27:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-29 15:29:13]

Patchset 3 (id:??) landed as
https://crrev.com/6f2fa9715bfc79d559f39077b34b0b71761ecb54
Cr-Commit-Position: refs/heads/master@{#327492}