Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: base/trace_event/memory_dump_provider.h

Issue 1107403003: base: Minor MemoryDumpProvider cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: restore explicit default ctor Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_TRACE_EVENT_MEMORY_DUMP_PROVIDER_H_ 5 #ifndef BASE_TRACE_EVENT_MEMORY_DUMP_PROVIDER_H_
6 #define BASE_TRACE_EVENT_MEMORY_DUMP_PROVIDER_H_ 6 #define BASE_TRACE_EVENT_MEMORY_DUMP_PROVIDER_H_
7 7
8 #include "base/base_export.h" 8 #include "base/base_export.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 10
11 namespace base { 11 namespace base {
12 namespace trace_event { 12 namespace trace_event {
13 13
14 class ProcessMemoryDump; 14 class ProcessMemoryDump;
15 15
16 // The contract interface that memory dump providers must implement. 16 // The contract interface that memory dump providers must implement.
17 class BASE_EXPORT MemoryDumpProvider { 17 class BASE_EXPORT MemoryDumpProvider {
18 public: 18 public:
19 // Called by the MemoryDumpManager when generating memory dumps. 19 // Called by the MemoryDumpManager when generating memory dumps.
20 // The embedder should return true if the |pmd| was successfully populated, 20 // The embedder should return true if the |pmd| was successfully populated,
21 // false if something went wrong and the dump should be considered invalid. 21 // false if something went wrong and the dump should be considered invalid.
22 // (Note, the MemoryDumpManager has a fail-safe logic which will disable the 22 // (Note, the MemoryDumpManager has a fail-safe logic which will disable the
23 // MemoryDumpProvider for the entire trace session if it fails consistently). 23 // MemoryDumpProvider for the entire trace session if it fails consistently).
24 virtual bool OnMemoryDump(ProcessMemoryDump* pmd) = 0; 24 virtual bool OnMemoryDump(ProcessMemoryDump* pmd) = 0;
25 25
26 protected: 26 protected:
27 MemoryDumpProvider() {} 27 MemoryDumpProvider() {}
28 virtual ~MemoryDumpProvider() {} 28 virtual ~MemoryDumpProvider() {}
29 29
30 private:
31 DISALLOW_COPY_AND_ASSIGN(MemoryDumpProvider); 30 DISALLOW_COPY_AND_ASSIGN(MemoryDumpProvider);
32 }; 31 };
33 32
34 } // namespace trace_event 33 } // namespace trace_event
35 } // namespace base 34 } // namespace base
36 35
37 #endif // BASE_TRACE_EVENT_MEMORY_DUMP_PROVIDER_H_ 36 #endif // BASE_TRACE_EVENT_MEMORY_DUMP_PROVIDER_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698