Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1107353004: align top and bounds computations (Closed)

Created:
5 years, 7 months ago by caryclark
Modified:
5 years, 7 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

minor fixes to cubics code and overall alignment of how bounds and tops are computed for all curve types All but 17 extended tests work. A helper function is privately added to SkPath.h to permit a test to modify a given point in a path. BUG=skia:3588 Committed: https://skia.googlesource.com/skia/+/aec251012542e971100e218bf463adbfb5d21d20

Patch Set 1 #

Patch Set 2 : clean up code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1606 lines, -884 lines) Patch
M gyp/core.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPath.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPath.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M src/pathops/SkDCubicLineIntersection.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pathops/SkOpContour.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpContour.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pathops/SkOpSegment.h View 3 chunks +12 lines, -4 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 5 chunks +21 lines, -12 lines 0 comments Download
M src/pathops/SkPathOpsBounds.h View 2 chunks +8 lines, -15 lines 0 comments Download
M src/pathops/SkPathOpsBounds.cpp View 1 1 chunk +0 lines, -51 lines 0 comments Download
M src/pathops/SkPathOpsCommon.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsConic.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsConic.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
M src/pathops/SkPathOpsCubic.h View 4 chunks +3 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsCubic.cpp View 6 chunks +39 lines, -50 lines 0 comments Download
M src/pathops/SkPathOpsCurve.h View 4 chunks +23 lines, -30 lines 0 comments Download
A src/pathops/SkPathOpsCurve.cpp View 1 chunk +146 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 2 chunks +3 lines, -7 lines 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsQuad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsQuad.cpp View 3 chunks +8 lines, -23 lines 0 comments Download
M src/pathops/SkPathOpsRect.h View 1 chunk +17 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsRect.cpp View 1 chunk +30 lines, -31 lines 0 comments Download
M src/pathops/SkPathOpsSimplify.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/PathOpsBoundsTest.cpp View 3 chunks +13 lines, -8 lines 0 comments Download
M tests/PathOpsCubicLineIntersectionTest.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/PathOpsDCubicTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsExtendedTest.cpp View 4 chunks +4 lines, -6 lines 0 comments Download
M tests/PathOpsIssue3651.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 2 chunks +990 lines, -287 lines 0 comments Download
M tests/PathOpsTestCommon.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/pathops_sorter.htm View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/pathops_visualizer.htm View 1 chunk +229 lines, -303 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107353004/1
5 years, 7 months ago (2015-04-28 20:58:33 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-28 21:04:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107353004/20001
5 years, 7 months ago (2015-04-29 12:40:50 UTC) #7
caryclark
please review public interface change
5 years, 7 months ago (2015-04-29 12:41:14 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-29 12:46:15 UTC) #10
reed1
lgtm
5 years, 7 months ago (2015-04-29 14:56:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107353004/20001
5 years, 7 months ago (2015-04-29 15:28:10 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 15:28:35 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/aec251012542e971100e218bf463adbfb5d21d20

Powered by Google App Engine
This is Rietveld 408576698