Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1107233002: Move runner stuff into a runner namespace. (Closed)

Created:
5 years, 8 months ago by Ben Goodger (Google)
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move runner stuff into a runner namespace. TBR=sky@chromium.org BUG= Committed: https://crrev.com/88c9571a2e1aef7c0c84397093ba3673e2f32c08 Cr-Commit-Position: refs/heads/master@{#327559}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -179 lines) Patch
M mojo/DEPS View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M mojo/runner/android/android_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/android/android_handler.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/runner/android/android_handler_loader.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/runner/android/android_handler_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/AndroidHandler.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/Bootstrap.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/MojoShellApplication.java View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/ShellMain.java View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/android/background_application_loader.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/runner/android/background_application_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/android/background_application_loader_unittest.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/runner/android/bootstrap.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/runner/android/library_loader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/runner/android/main.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/runner/android/main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/android/native_viewport_application_loader.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/runner/android/native_viewport_application_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/android/run_android_application_function.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/android/tests/src/org/chromium/mojo/shell/ShellTestBase.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/android/ui_application_loader_android.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/runner/android/ui_application_loader_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/child_process.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/runner/child_process.cc View 1 2 3 4 4 chunks +9 lines, -9 lines 0 comments Download
M mojo/runner/child_process.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/child_process_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/child_process_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/child_process_host_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/context.h View 4 chunks +7 lines, -5 lines 0 comments Download
M mojo/runner/context.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M mojo/runner/data_pipe_peek_unittest.cc View 5 chunks +17 lines, -12 lines 0 comments Download
M mojo/runner/desktop/launcher_process.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/runner/desktop/launcher_process.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/runner/desktop/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/runner/in_process_native_runner.h View 1 2 3 5 chunks +7 lines, -7 lines 0 comments Download
M mojo/runner/in_process_native_runner.cc View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M mojo/runner/in_process_native_runner_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/init.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/runner/init.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/native_application_support.h View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/runner/native_application_support.cc View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M mojo/runner/native_runner_unittest.cc View 1 2 3 7 chunks +12 lines, -12 lines 0 comments Download
M mojo/runner/out_of_process_native_runner.h View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M mojo/runner/out_of_process_native_runner.cc View 1 2 3 5 chunks +6 lines, -5 lines 0 comments Download
M mojo/runner/shell_test_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/shell_test_base.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/shell_test_base_android.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/shell_test_base_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/shell_test_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/task_runners.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/task_runners.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/url_resolver.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/url_resolver.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/runner/url_resolver_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/application_manager.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/native_runner.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M mojo/tools/mopy/paths.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Ben Goodger (Google)
5 years, 7 months ago (2015-04-28 22:42:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107233002/20001
5 years, 7 months ago (2015-04-28 22:43:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107233002/60001
5 years, 7 months ago (2015-04-29 20:14:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/60014)
5 years, 7 months ago (2015-04-29 20:23:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107233002/80001
5 years, 7 months ago (2015-04-29 20:29:43 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-04-29 21:30:21 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 21:31:49 UTC) #12
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/88c9571a2e1aef7c0c84397093ba3673e2f32c08
Cr-Commit-Position: refs/heads/master@{#327559}

Powered by Google App Engine
This is Rietveld 408576698