Make calls to AtomicString(const String&) explicit in editing/

Make calls to AtomicString(const String&) explicit in editing/

Make calls to AtomicString(const String&) explicit in editing/ and avoid
useless conversions from String to AtomicString when possible.

This is one step towards making the AtomicString(const String&) constructor
explicit. This CL takes care only of the editing/ part so that it is more
easily reviewable.

R=eseidel, abarth
BUG=323739
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163805

[Inactive, 2013-12-09 22:44:10]

https://codereview.chromium.org/110723005/diff/1/Source/core/editing/ApplySty...
File Source/core/editing/ApplyStyleCommand.cpp (right):

https://codereview.chromium.org/110723005/diff/1/Source/core/editing/ApplySty...
Source/core/editing/ApplyStyleCommand.cpp:403: setNodeAttribute(element.get(),
styleAttr, AtomicString(inlineStyle->asText()));
It seems several callers of asText() expect an AtomicString instead of a String.
I guess we could make asText() templated so that it could return either an
AtomicString or a String (it is using a StringBuilder internally) but I am not
sure it is worth the trouble. It seems all the callers that expect an
AtomicString are in editing/.

Please let me know if you think we should do this instead.

[Inactive, 2013-12-12 15:38:45]

On 2013/12/09 22:44:10, Chris Dumez wrote:
>
https://codereview.chromium.org/110723005/diff/1/Source/core/editing/ApplySty...
> File Source/core/editing/ApplyStyleCommand.cpp (right):
> 
>
https://codereview.chromium.org/110723005/diff/1/Source/core/editing/ApplySty...
> Source/core/editing/ApplyStyleCommand.cpp:403: setNodeAttribute(element.get(),
> styleAttr, AtomicString(inlineStyle->asText()));
> It seems several callers of asText() expect an AtomicString instead of a
String.
> I guess we could make asText() templated so that it could return either an
> AtomicString or a String (it is using a StringBuilder internally) but I am not
> sure it is worth the trouble. It seems all the callers that expect an
> AtomicString are in editing/.
> 
> Please let me know if you think we should do this instead.

ping review?

[abarth-chromium, 2013-12-12 18:37:51]

lgtm

https://codereview.chromium.org/110723005/diff/1/Source/core/editing/ApplySty...
File Source/core/editing/ApplyStyleCommand.cpp (right):

https://codereview.chromium.org/110723005/diff/1/Source/core/editing/ApplySty...
Source/core/editing/ApplyStyleCommand.cpp:403: setNodeAttribute(element.get(),
styleAttr, AtomicString(inlineStyle->asText()));
On 2013/12/09 22:44:10, Chris Dumez wrote:
> It seems several callers of asText() expect an AtomicString instead of a
String.
> I guess we could make asText() templated so that it could return either an
> AtomicString or a String (it is using a StringBuilder internally) but I am not
> sure it is worth the trouble. It seems all the callers that expect an
> AtomicString are in editing/.
> 
> Please let me know if you think we should do this instead.

Hum...  I don't have a strong opinion here.

[commit-bot: I haz the power, 2013-12-12 18:38:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/110723005/1

[commit-bot: I haz the power, 2013-12-12 19:43:24]

Change committed as 163805