Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: Source/core/editing/CreateLinkCommand.cpp

Issue 110723005: Make calls to AtomicString(const String&) explicit in editing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 25 matching lines...) Expand all
36 { 36 {
37 m_url = url; 37 m_url = url;
38 } 38 }
39 39
40 void CreateLinkCommand::doApply() 40 void CreateLinkCommand::doApply()
41 { 41 {
42 if (endingSelection().isNone()) 42 if (endingSelection().isNone())
43 return; 43 return;
44 44
45 RefPtr<HTMLAnchorElement> anchorElement = HTMLAnchorElement::create(document ()); 45 RefPtr<HTMLAnchorElement> anchorElement = HTMLAnchorElement::create(document ());
46 anchorElement->setHref(m_url); 46 anchorElement->setHref(AtomicString(m_url));
47 47
48 if (endingSelection().isRange()) 48 if (endingSelection().isRange())
49 applyStyledElement(anchorElement.get()); 49 applyStyledElement(anchorElement.get());
50 else { 50 else {
51 insertNodeAt(anchorElement.get(), endingSelection().start()); 51 insertNodeAt(anchorElement.get(), endingSelection().start());
52 RefPtr<Text> textNode = Text::create(document(), m_url); 52 RefPtr<Text> textNode = Text::create(document(), m_url);
53 appendNode(textNode.get(), anchorElement.get()); 53 appendNode(textNode.get(), anchorElement.get());
54 setEndingSelection(VisibleSelection(positionInParentBeforeNode(anchorEle ment.get()), positionInParentAfterNode(anchorElement.get()), DOWNSTREAM, endingS election().isDirectional())); 54 setEndingSelection(VisibleSelection(positionInParentBeforeNode(anchorEle ment.get()), positionInParentAfterNode(anchorElement.get()), DOWNSTREAM, endingS election().isDirectional()));
55 } 55 }
56 } 56 }
57 57
58 } 58 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698