Issue 1107163002: Sandbox windows not provided to chrome.app.window.create.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1107163002: Sandbox windows not provided to chrome.app.window.create. (Closed)

Created:
5 years, 7 months ago by scheib

Modified:
5 years, 7 months ago

Reviewers:
benwells

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Sandbox windows not provided to chrome.app.window.create. Documented in developer console, avoiding raising an exception, and on developer documentation page sample. BUG=154662 Committed: https://crrev.com/203a1880d725020ac6e70f5b1ba9c1ffb48577d4 Cr-Commit-Position: refs/heads/master@{#327421}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -9 lines)			Patch
	M	chrome/common/extensions/docs/templates/articles/app_external.html	View		1 chunk	+4 lines, -7 lines	0 comments	Download
	M	extensions/renderer/resources/app_window_custom_bindings.js	View		1 chunk	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107163002/1

5 years, 7 months ago (2015-04-28 23:58:59 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-04-29 02:26:12 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/203a1880d725020ac6e70f5b1ba9c1ffb48577d4
Cr-Commit-Position: refs/heads/master@{#327421}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages