chrome/common/extensions/docs/templates/articles/app_external.html - Issue 1107163002: Sandbox windows not provided to chrome.app.window.create.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/templates/articles/app_external.html

Issue 1107163002: Sandbox windows not provided to chrome.app.window.create. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/docs/templates/articles/app_external.html

diff --git a/chrome/common/extensions/docs/templates/articles/app_external.html b/chrome/common/extensions/docs/templates/articles/app_external.html

index e702ddce55caebd48206d17a75562505f8e07c6e..4a13504ce5a4a35c316fb03a5627cc07472b035d 100644

--- a/chrome/common/extensions/docs/templates/articles/app_external.html

+++ b/chrome/common/extensions/docs/templates/articles/app_external.html

@@ -178,14 +178,11 @@ one for the main app window that isn't sandboxed,

and one for the sandboxed page:

</p>

-<p class="warning">

+<p class="note">

NOTE:

-<a href="https://code.google.com/p/chromium/issues/detail?id=154662">issue 154662</a>

-is a bug when using sandbox pages to create windows.

-The effect is that an error "Uncaught TypeError: Cannot call method

-'initializeAppWindow' of undefined" is output to the developer console

-and that the app.window.create call does not call the callback function

-with a window object. However, the sandbox page is created as a new window.

+A sandboxed window will not have access to the chrome.app APIs. If a

+callback is provided to app.window.create it will be run, but will not have

+the sandboxed window provided to it.

</p>

« no previous file with comments | « no previous file | extensions/renderer/resources/app_window_custom_bindings.js » ('j') | no next file with comments »