Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: tools/testing/dart/test_progress.dart

Issue 11071003: Fix test.dart return code -- was causing fake greenness on dartc, dart2dart (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tests/co19/co19-compiler.status ('K') | « tests/co19/co19-compiler.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_progress.dart
===================================================================
--- tools/testing/dart/test_progress.dart (revision 13334)
+++ tools/testing/dart/test_progress.dart (working copy)
@@ -86,7 +86,7 @@
_printTimingInformation();
stdout.close();
stderr.close();
- if (_failedTests) exit(1);
+ if (_failedTests > 0) exit(1);
Mads Ager (google) 2012/10/06 06:16:36 Oh my. :(
Ivan Posva 2012/10/11 04:40:39 Shouldn't this have failed in checked mode? Maybe
}
void _printStartProgress(TestCase test) {}
@@ -235,7 +235,7 @@
}
stdout.close();
stderr.close();
- if (_failedTests) exit(1);
+ if (_failedTests > 0) exit(1);
}
void allTestsKnown() {
« tests/co19/co19-compiler.status ('K') | « tests/co19/co19-compiler.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698