Fix test.dart return code -- was causing fake greenness on dartc, dart2dart

tools/testing/dart/test_progress.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("test_progress");
 
 #import("dart:io");
 #import("test_runner.dart");
 #import("test_suite.dart");
 
@@ skipping 68 matching lines @@
       }
     }
   }
 
   void allDone() {
     _printFailureSummary();
     _printStatus();
     _printTimingInformation();
     stdout.close();
     stderr.close();
-    if (_failedTests) exit(1);
+    if (_failedTests > 0) exit(1);

[Mads Ager (google), 2012/10/06 06:16:36]

Oh my. :(

[Ivan Posva, 2012/10/11 04:40:39]

Shouldn't this have failed in checked mode? Maybe it is time to run the test
harness in checked mode occasionally? Or at least when modifying the harness
itself?

   }
 
   void _printStartProgress(TestCase test) {}
   void _printDoneProgress(TestCase test) {}
 
   String _pad(String s, int length) {
     StringBuffer buffer = new StringBuffer();
     for (int i = s.length; i < length; i++) {
       buffer.add(' ');
     }
@@ skipping 128 matching lines @@
     stdout.write('\n'.charCodes());
     _printFailureSummary();
     _printTimingInformation();
     if (_failedTests > 0) {
       // We may have printed many failure logs, so reprint the summary data.
       _printProgress();
       print('');
     }
     stdout.close();
     stderr.close();
-    if (_failedTests) exit(1);
+    if (_failedTests > 0) exit(1);
   }
 
   void allTestsKnown() {
     if (!_allTestsKnown && SummaryReport.total > 0) {
       // Clear progress indicator before printing summary report.
       stdout.write(
           '\r                                               \r'.charCodes());
       SummaryReport.printReport();
     }
     _allTestsKnown = true;
@@ skipping 152 matching lines @@
       print('');
       print('$key:');
       lines.sort((a, b) => a.compareTo(b));
       for (String line in lines) {
         print('  $line');
       }
     });
     _printStatus();
   }
 }