Moves the notification icon out of the status area overflow.

chrome/browser/status_icons/status_icon.h

Index: chrome/browser/status_icons/status_icon.h
diff --git a/chrome/browser/status_icons/status_icon.h b/chrome/browser/status_icons/status_icon.h
index 7cb88992914f88f553d786feb0011c1939cf57ff..c8b19ddca75d02cbe344c48fb7f1d37fe1ca0910 100644
--- a/chrome/browser/status_icons/status_icon.h
+++ b/chrome/browser/status_icons/status_icon.h
@@ -17,6 +17,10 @@ class ImageSkia;
 
 class StatusIconObserver;
 
+#if defined(OS_WIN)
+class StatusIconWin;

[Andrew T Wilson (Slow), 2014/03/21 09:15:13]

Yeah, I don't like this, even though I understand why you don't like static
casts. It's OK for code running on OS_WIN to assume that all StatusIcons are
actually StatusIconWins, and just do a static cast.

Taking a step back, it seems like you only need StatusIconWin for two reasons:

1) In WebNotificationTray::EnforceStatusIconVisible() to make a status icon
visible.
2) In a browser test to grab out some window internals.

Instead of putting the functionality to make a status icon visible into a
separate class, consider exposing a virtual ForceVisible() API on this class.
This would be a no-op on most platforms, but StatusIconWin() could basically do
what WebNotificationTray::EnforceStatusIconVisible() does now, and
WebNotificationTray::EnforceStatusIconVisible() could just call
status_icon_->ForceVisible().

I think that fits in better with the overall class design. And for the browser
test you can do whatever (static casts, etc - it's just a test).

[sky, 2014/03/21 16:11:22]

+1

[dewittj, 2014/04/01 17:58:09]

Done.

+#endif  // defined(OS_WIN)
+
 class StatusIcon {
  public:
   StatusIcon();
@@ -56,8 +60,14 @@ class StatusIcon {
 
   // Dispatches a click event to the observers.
   void DispatchClickEvent();
+
 #if defined(OS_WIN)
+  // Dispatches a balloon click event to the observers.
   void DispatchBalloonClickEvent();
+
+  // Available on Windows so clients can access Windows-specific functionality
+  // like the backing HWND.
+  StatusIconWin* AsStatusIconWin();
 #endif
 
  protected: