Moves the notification icon out of the status area overflow.

chrome/browser/status_icons/status_icon.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_STATUS_ICONS_STATUS_ICON_H_
 #define CHROME_BROWSER_STATUS_ICONS_STATUS_ICON_H_
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/observer_list.h"
 #include "base/strings/string16.h"
 #include "chrome/browser/status_icons/status_icon_menu_model.h"
 
 namespace gfx {
 class ImageSkia;
 }
 
 class StatusIconObserver;
 
+#if defined(OS_WIN)
+class StatusIconWin;

[Andrew T Wilson (Slow), 2014/03/21 09:15:13]

Yeah, I don't like this, even though I understand why you don't like static
casts. It's OK for code running on OS_WIN to assume that all StatusIcons are
actually StatusIconWins, and just do a static cast.

Taking a step back, it seems like you only need StatusIconWin for two reasons:

1) In WebNotificationTray::EnforceStatusIconVisible() to make a status icon
visible.
2) In a browser test to grab out some window internals.

Instead of putting the functionality to make a status icon visible into a
separate class, consider exposing a virtual ForceVisible() API on this class.
This would be a no-op on most platforms, but StatusIconWin() could basically do
what WebNotificationTray::EnforceStatusIconVisible() does now, and
WebNotificationTray::EnforceStatusIconVisible() could just call
status_icon_->ForceVisible().

I think that fits in better with the overall class design. And for the browser
test you can do whatever (static casts, etc - it's just a test).

[sky, 2014/03/21 16:11:22]

+1

[dewittj, 2014/04/01 17:58:09]

Done.

+#endif  // defined(OS_WIN)
+
 class StatusIcon {
  public:
   StatusIcon();
   virtual ~StatusIcon();
 
   // Sets the image associated with this status icon.
   virtual void SetImage(const gfx::ImageSkia& image) = 0;
 
   // Sets the image associated with this status icon when pressed.
   virtual void SetPressedImage(const gfx::ImageSkia& image) = 0;
@@ skipping 19 matching lines @@
   // being called, otherwise, both left and right clicks will display the
   // context menu (if any).
   void AddObserver(StatusIconObserver* observer);
   void RemoveObserver(StatusIconObserver* observer);
 
   // Returns true if there are registered click observers.
   bool HasObservers() const;
 
   // Dispatches a click event to the observers.
   void DispatchClickEvent();
+
 #if defined(OS_WIN)
+  // Dispatches a balloon click event to the observers.
   void DispatchBalloonClickEvent();
+
+  // Available on Windows so clients can access Windows-specific functionality
+  // like the backing HWND.
+  StatusIconWin* AsStatusIconWin();
 #endif
 
  protected:
   // Invoked after a call to SetContextMenu() to let the platform-specific
   // subclass update the native context menu based on the new model. If NULL is
   // passed, subclass should destroy the native context menu.
   virtual void UpdatePlatformContextMenu(StatusIconMenuModel* model) = 0;
 
  private:
   ObserverList<StatusIconObserver> observers_;
 
   // Context menu, if any.
   scoped_ptr<StatusIconMenuModel> context_menu_contents_;
 
   DISALLOW_COPY_AND_ASSIGN(StatusIcon);
 };
 
 #endif  // CHROME_BROWSER_STATUS_ICONS_STATUS_ICON_H_