Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1106843003: Remove redundant chromeos checks from GN build. (Closed)

Created:
5 years, 8 months ago by brettw
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@wincomp_sync_ui
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant chromeos checks from GN build. This addresses code review comments from https://codereview.chromium.org/1104703004 TBR=dpranke@chromium.org Committed: https://crrev.com/7b7c14bdb043a4f3d4557e6f590038afad7525bf Cr-Commit-Position: refs/heads/master@{#326930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -27 lines) Patch
M ui/display/BUILD.gn View 3 chunks +19 lines, -27 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years, 8 months ago (2015-04-24 22:29:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106843003/1
5 years, 8 months ago (2015-04-24 22:45:08 UTC) #4
Dirk Pranke
lgtm
5 years, 8 months ago (2015-04-24 22:47:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/31106)
5 years, 8 months ago (2015-04-24 22:52:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106843003/1
5 years, 8 months ago (2015-04-24 23:02:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 23:24:25 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 23:25:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b7c14bdb043a4f3d4557e6f590038afad7525bf
Cr-Commit-Position: refs/heads/master@{#326930}

Powered by Google App Engine
This is Rietveld 408576698