Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1104703004: Windows GN component build fixes: sync, ui (Closed)

Created:
5 years, 8 months ago by brettw
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Windows GN component build fixes: sync, ui TBR=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/d20473d166912de9d8f271c7bdabc75ee60a42f0 Cr-Commit-Position: refs/heads/master@{#326911}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -112 lines) Patch
M sync/BUILD.gn View 3 chunks +3 lines, -2 lines 0 comments Download
M sync/internal_api/attachments/proto/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/display/BUILD.gn View 3 chunks +114 lines, -110 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
brettw
Split off of https://codereview.chromium.org/1071633003/, carrying review over.
5 years, 8 months ago (2015-04-24 21:51:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104703004/1
5 years, 8 months ago (2015-04-24 21:52:07 UTC) #3
Dirk Pranke
lgtm https://codereview.chromium.org/1104703004/diff/1/ui/display/BUILD.gn File ui/display/BUILD.gn (right): https://codereview.chromium.org/1104703004/diff/1/ui/display/BUILD.gn#newcode58 ui/display/BUILD.gn:58: if (is_chromeos) { these (here and line 63) ...
5 years, 8 months ago (2015-04-24 22:02:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 22:34:59 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 22:35:52 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d20473d166912de9d8f271c7bdabc75ee60a42f0
Cr-Commit-Position: refs/heads/master@{#326911}

Powered by Google App Engine
This is Rietveld 408576698