Emulate GL_PRIMITIVE_RESTART_FIXED_INDEX: part I

gpu/command_buffer/service/context_state.cc

Index: gpu/command_buffer/service/context_state.cc
diff --git a/gpu/command_buffer/service/context_state.cc b/gpu/command_buffer/service/context_state.cc
index 05ea8af6950f8977fcf9ca331c4b682d2aad71b4..5c5da8275053b1abfc106abf9dea885472572854 100644
--- a/gpu/command_buffer/service/context_state.cc
+++ b/gpu/command_buffer/service/context_state.cc
@@ -285,16 +285,8 @@ ErrorState* ContextState::GetErrorState() {
 
 void ContextState::EnableDisable(GLenum pname, bool enable) const {
   if (pname == GL_PRIMITIVE_RESTART_FIXED_INDEX) {
-    // This is only available on Desktop GL 4.3+, but we emulate ES 3.0 on top
-    // of Desktop GL 4.2+.
-    const gfx::GLVersionInfo& gl_version = feature_info_->gl_version_info();
-    if (!gl_version.is_es &&
-        (gl_version.major_version < 4 ||
-         (gl_version.major_version == 4 && gl_version.minor_version < 3))) {
-      // TODO(zmo): Ignoring it may not be the best emulation.
-      NOTIMPLEMENTED();

[Zhenyao Mo, 2015/04/24 21:40:42]

We need to remove this NOTIMPLEMENTED() because it spits out too many lines in
WebGL conformance tests on Linux GPU bot (which is GL 4.1).

This path is hit because we do ES3 states querying on top of ES3 capable
context, not ES3 enabled context, and GL 4.1 is currently considered as ES3
capable.

We are turning on WebGL 2 conformance tests soon, so we need to remove this
warning line anyway.

-      return;
-    }
+    if (feature_info_->feature_flags().emulate_primitive_restart_fixed_index)
+      pname = GL_PRIMITIVE_RESTART;
   }
   if (enable) {
     glEnable(pname);