Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 110683002: Split the hole punching logic from GOOGLE_TV ifdef to VIDEO_HOLE (Closed)

Created:
7 years ago by qinmin
Modified:
7 years ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Split the hole punching logic from GOOGLE_TV #ifdef into VIDEO_HOLE This CL splits the hole punching logic into another ifdef, so that the code can be reused by different parties and can be easily managed See discussion: https://groups.google.com/a/google.com/forum/#!topic/chrome-gpu/eIM1RwarUmk BUG=323157 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240365

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -82 lines) Patch
M build/common.gypi View 1 1 chunk +4 lines, -1 line 0 comments Download
M cc/layers/video_layer_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M cc/resources/video_resource_updater.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/media/media_player_messages_android.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 3 chunks +8 lines, -11 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 9 chunks +25 lines, -18 lines 0 comments Download
M media/base/video_frame.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M media/base/video_frame.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
qinmin
PTAL
7 years ago (2013-12-09 20:48:05 UTC) #1
qinmin
+ycheo and scherkus for gtv and media/
7 years ago (2013-12-10 16:47:15 UTC) #2
enne (OOO)
Why does this need to be #ifdef'd at all?
7 years ago (2013-12-10 18:19:52 UTC) #3
qinmin
On 2013/12/10 18:19:52, enne wrote: > Why does this need to be #ifdef'd at all? ...
7 years ago (2013-12-10 18:43:42 UTC) #4
enne (OOO)
On 2013/12/10 18:43:42, qinmin wrote: > On 2013/12/10 18:19:52, enne wrote: > > Why does ...
7 years ago (2013-12-10 18:49:31 UTC) #5
ycheo (away)
lgtm
7 years ago (2013-12-11 06:39:42 UTC) #6
qinmin
darin@, would you please help take a look at this?
7 years ago (2013-12-11 20:46:28 UTC) #7
darin (slow to review)
LGTM
7 years ago (2013-12-11 21:47:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/110683002/1
7 years ago (2013-12-11 21:51:31 UTC) #9
commit-bot: I haz the power
Failed to apply patch for content/browser/media/android/browser_media_player_manager.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-11 21:51:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/110683002/20001
7 years ago (2013-12-11 22:48:13 UTC) #11
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=40743
7 years ago (2013-12-11 23:03:54 UTC) #12
qinmin
+palmer for OWNER of IPC
7 years ago (2013-12-11 23:07:28 UTC) #13
palmer
lgtm
7 years ago (2013-12-11 23:31:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/110683002/20001
7 years ago (2013-12-11 23:39:15 UTC) #15
commit-bot: I haz the power
7 years ago (2013-12-12 18:23:15 UTC) #16
Message was sent while issue was closed.
Change committed as 240365

Powered by Google App Engine
This is Rietveld 408576698