Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2340)

Unified Diff: content/renderer/media/android/webmediaplayer_android.h

Issue 110683002: Split the hole punching logic from GOOGLE_TV ifdef to VIDEO_HOLE (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/android/webmediaplayer_android.h
diff --git a/content/renderer/media/android/webmediaplayer_android.h b/content/renderer/media/android/webmediaplayer_android.h
index fd6555e22729bda9f7595ff48f480101853e7d20..40582ca1c8adad1304251699ae2702d4ca3b85a9 100644
--- a/content/renderer/media/android/webmediaplayer_android.h
+++ b/content/renderer/media/android/webmediaplayer_android.h
@@ -191,12 +191,12 @@ class WebMediaPlayerAndroid
// Detach the player from its manager.
void Detach();
-#if defined(GOOGLE_TV)
+#if defined(VIDEO_HOLE)
// Retrieve geometry of the media player (i.e. location and size of the video
// frame) if changed. Returns true only if the geometry has been changed since
// the last call.
bool RetrieveGeometryChange(gfx::RectF* rect);
-#endif
+#endif // defined(VIDEO_HOLE)
virtual MediaKeyException generateKeyRequest(
const blink::WebString& key_system,
@@ -256,11 +256,6 @@ class WebMediaPlayerAndroid
// Requesting whether the surface texture peer needs to be reestablished.
void SetNeedsEstablishPeer(bool needs_establish_peer);
-#if defined(GOOGLE_TV)
- // Request external surface for out-of-band composition.
- void RequestExternalSurface();
-#endif
-
private:
void DrawRemotePlaybackIcon();
void ReallocateVideoFrame();
@@ -401,15 +396,17 @@ class WebMediaPlayerAndroid
scoped_ptr<webkit::WebLayerImpl> video_weblayer_;
+#if defined(VIDEO_HOLE)
+ // A rectangle represents the geometry of video frame, when computed last
+ // time.
+ gfx::RectF last_computed_rect_;
+#endif // defined(VIDEO_HOLE)
+
#if defined(GOOGLE_TV)
// Pixel threshold for external surface usage. Negative value means that the
// threshold is not defined, so that external surface is never used.
int external_surface_threshold_;
- // A rectangle represents the geometry of video frame, when computed last
- // time.
- gfx::RectF last_computed_rect_;
-
// Media Stream related fields.
media::Demuxer* demuxer_;
base::Closure destroy_demuxer_cb_;

Powered by Google App Engine
This is Rietveld 408576698