Issue 1106663002: Merge to XFA: Kill overloaded cast operators in CJS_Value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1106663002: Merge to XFA: Kill overloaded cast operators in CJS_Value. (Closed)

Created:
5 years, 8 months ago by Tom Sepez

Modified:
5 years, 8 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+305 lines, -362 lines)			Patch
M	fpdfsdk/include/javascript/JS_Define.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Value.h	View	1 chunk	+10 lines, -10 lines	0 comments	Download
M	fpdfsdk/src/javascript/Document.cpp	View	17 chunks	+72 lines, -67 lines	0 comments	Download
M	fpdfsdk/src/javascript/Field.cpp	View	13 chunks	+32 lines, -39 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Value.cpp	View	12 chunks	+23 lines, -34 lines	0 comments	Download
M	fpdfsdk/src/javascript/PublicMethods.cpp	View	27 chunks	+66 lines, -82 lines	0 comments	Download
M	fpdfsdk/src/javascript/app.cpp	View	16 chunks	+73 lines, -86 lines	0 comments	Download
M	fpdfsdk/src/javascript/color.cpp	View	3 chunks	+7 lines, -9 lines	0 comments	Download
M	fpdfsdk/src/javascript/event.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/javascript/global.cpp	View	4 chunks	+6 lines, -17 lines	0 comments	Download
M	fpdfsdk/src/javascript/util.cpp	View	7 chunks	+12 lines, -14 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as f4ef3f92eb89a460a0715df758122ba662aadc39 (presubmit successful).

5 years, 8 months ago (2015-04-23 18:31:34 UTC) #2

Message was sent while issue was closed.

lgtm