Merge to XFA: Kill overloaded cast operators in CJS_Value.

fpdfsdk/src/javascript/app.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_Object.h"
@@ skipping 320 matching lines @@
         CFX_WideString swTitle = L"";
         int iIcon = 0;
         int iType = 0;
 
         v8::Isolate* isolate = GetIsolate(cc);
 
         if (iSize == 1)
         {
                 if (params[0].GetType() == VT_object)
                 {
-                        JSObject pObj = params[0];
+                        JSObject pObj = params[0].ToV8Object();
                         {
                                 v8::Handle<v8::Value> pValue = JS_GetObjectElement(isolate, pObj, L"cMsg");
-                                swMsg = CJS_Value(isolate,pValue,VT_unknown).operator CFX_WideString();
+                                swMsg = CJS_Value(isolate, pValue, VT_unknown).ToCFXWideString();
 
-                                pValue = JS_GetObjectElement(isolate,pObj,L"cTitle");
-                                swTitle = CJS_Value(isolate, pValue,VT_unknown).operator CFX_WideString();
+                                pValue = JS_GetObjectElement(isolate, pObj, L"cTitle");
+                                swTitle = CJS_Value(isolate, pValue, VT_unknown).ToCFXWideString();
 
-                                pValue = JS_GetObjectElement(isolate,pObj,L"nIcon");
-                                iIcon = (int)CJS_Value(isolate,pValue,VT_unknown);
+                                pValue = JS_GetObjectElement(isolate, pObj, L"nIcon");
+                                iIcon = CJS_Value(isolate, pValue, VT_unknown).ToInt();
 
-                                pValue = JS_GetObjectElement(isolate,pObj,L"nType");
-                                iType = (int)CJS_Value(isolate,pValue,VT_unknown);
+                                pValue = JS_GetObjectElement(isolate, pObj, L"nType");
+                                iType = CJS_Value(isolate, pValue, VT_unknown).ToInt();
                         }
 
                         if (swMsg == L"")
                         {
                                 CJS_Array carray(isolate);
                                 if (params[0].ConvertToArray(carray))
                                 {
                                         int iLenth = carray.GetLength();
                                         CJS_Value* pValue = new CJS_Value(isolate);
 //                                      if (iLenth == 1)
 //                                              pValue = new CJS_Value(isolate);
 //                                      else if (iLenth > 1)
 //                                              pValue = new CJS_Value[iLenth];
 
                                         for(int i = 0; i < iLenth; i++)
                                         {
                                                 carray.GetElement(i, *pValue);
-                                                swMsg += (*pValue).operator CFX_WideString();
+                                                swMsg += (*pValue).ToCFXWideString();
                                                 if (i < iLenth - 1)
                                                         swMsg += L",  ";
                                         }
 
                                         if(pValue) delete pValue;
-//                                      if ((iLenth > 1) && pValue)
-//                                      {
-//                                              delete[]pValue;
-//                                              pValue = NULL;
-//                                      }
-//                                      else if ((iLenth == 1) && pValue)
-//                                      {
-//                                              delete pValue;
-//                                              pValue = NULL;
-//                                      }
                                 }
                         }
 
                         if (swTitle == L"")
                                 swTitle = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSALERT);
                 }
                 else if (params[0].GetType() == VT_boolean)
                 {
-                        FX_BOOL bGet = (FX_BOOL)params[0];
+                        FX_BOOL bGet = params[0].ToBool();
                         if (bGet)
                                 swMsg = L"true";
                         else
                                 swMsg = L"false";
 
                         swTitle = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSALERT);
                 }
                 else
                 {
-                        swMsg = params[0];
+                        swMsg = params[0].ToCFXWideString();
                         swTitle = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSALERT);
                 }
         }
         else
         {
                 if (params[0].GetType() == VT_boolean)
                 {
-                        FX_BOOL bGet = (FX_BOOL)params[0];
+                        FX_BOOL bGet = params[0].ToBool();
                         if (bGet)
                                 swMsg = L"true";
                         else
                                 swMsg = L"false";
                 }
                 else
                 {
-                        swMsg = params[0];
+                        swMsg = params[0].ToCFXWideString();
                 }
                 swTitle = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSALERT);
 
                 for(int i = 1;i<iSize;i++)
                 {
                         if (i == 1)
-                                iIcon = int(params[i]);
+                                iIcon = params[i].ToInt();
                         if (i == 2)
-                                iType = int(params[i]);
+                                iType = params[i].ToInt();
                         if (i == 3)
-                                swTitle = params[i];
+                                swTitle = params[i].ToCFXWideString();
                 }
         }
 
 
         CJS_Context* pContext = (CJS_Context*)cc;
         ASSERT(pContext != NULL);
         CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         ASSERT(pRuntime != NULL);
         pRuntime->BeginBlock();
         vRet = MsgBox(pRuntime->GetReaderApp(), JSGetPageView(cc),swMsg,swTitle,iType,iIcon);
         pRuntime->EndBlock();
 
         return TRUE;
 }
 
 
 FX_BOOL app::beep(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         if (params.size() == 1)
         {
                 CJS_Context* pContext = (CJS_Context*)cc;
                 CJS_Runtime* pRuntime = pContext->GetJSRuntime();
                 CPDFDoc_Environment * pEnv = pRuntime->GetReaderApp();
-                pEnv->JS_appBeep((int)params[0]);
-
+                pEnv->JS_appBeep(params[0].ToInt());
                 return TRUE;
         }
-        else
-        {
-                sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSPARAMERROR);
-                return FALSE;
-        }
+
+        sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSPARAMERROR);
+        return FALSE;
 }
 
 FX_BOOL app::findComponent(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         return TRUE;
 }
 
 FX_BOOL app::popUpMenuEx(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         return FALSE;
@@ skipping 10 matching lines @@
         {
                 sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSPARAMERROR);
                 return FALSE;
         }
 
         CJS_Context* pContext = (CJS_Context*)cc;
         ASSERT(pContext != NULL);
         CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         ASSERT(pRuntime != NULL);
 
-        CFX_WideString script = params.size() > 0 ?  (FX_LPCWSTR)(params[0].operator CFX_WideString()) : L"";
+        CFX_WideString script = params.size() > 0 ?  (FX_LPCWSTR)(params[0].ToCFXWideString()) : L"";
         if (script.IsEmpty())
         {
                 sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSAFNUMBER_KEYSTROKE);
                 return TRUE;
         }
 
-        FX_DWORD dwInterval = params.size() > 1 ? (int)params[1] : 1000;
+        FX_DWORD dwInterval = params.size() > 1 ? params[1].ToInt() : 1000;
 
         CPDFDoc_Environment* pApp = pRuntime->GetReaderApp();
         ASSERT(pApp);
         CJS_Timer* pTimer = new CJS_Timer(this, pApp);
         m_aTimer.Add(pTimer);
 
         pTimer->SetType(0);
         pTimer->SetRuntime(pRuntime);
         pTimer->SetJScript(script);
         pTimer->SetTimeOut(0);
@@ skipping 21 matching lines @@
         {
                 sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSPARAMERROR);
                 return FALSE;
         }
 
         CJS_Context* pContext = (CJS_Context*)cc;
         ASSERT(pContext != NULL);
         CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         ASSERT(pRuntime != NULL);
 
-        CFX_WideString script = params.size() > 0 ?  (FX_LPCWSTR)(params[0].operator CFX_WideString()) : L"";
+        CFX_WideString script = params.size() > 0 ?  (FX_LPCWSTR)(params[0].ToCFXWideString()) : L"";
         if (script.IsEmpty())
         {
                 sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSAFNUMBER_KEYSTROKE);
                 return TRUE;
         }
 
-        FX_DWORD dwTimeOut = params.size() > 1 ? (int)params[1] : 1000;
+        FX_DWORD dwTimeOut = params.size() > 1 ? params[1].ToInt() : 1000;
 
         CPDFDoc_Environment* pApp = pRuntime->GetReaderApp();
         ASSERT(pApp);
+
         CJS_Timer* pTimer = new CJS_Timer(this, pApp);
         m_aTimer.Add(pTimer);
 
         pTimer->SetType(1);
         pTimer->SetRuntime(pRuntime);
         pTimer->SetJScript(script);
         pTimer->SetTimeOut(dwTimeOut);
-//      pTimer->SetStartTime(GetTickCount());
-//      pTimer->SetJSTimer(1000);
         pTimer->SetJSTimer(dwTimeOut);
 
         JSFXObject pRetObj = JS_NewFxDynamicObj(*pRuntime, pContext, JS_GetObjDefnID(*pRuntime, L"TimerObj"));
-//      ASSERT(pRetObj != NULL);
 
         CJS_TimerObj* pJS_TimerObj = (CJS_TimerObj*)JS_GetPrivate(pRuntime->GetIsolate(),pRetObj);
         ASSERT(pJS_TimerObj != NULL);
 
         TimerObj* pTimerObj = (TimerObj*)pJS_TimerObj->GetEmbedObject();
         ASSERT(pTimerObj != NULL);
 
         pTimerObj->SetTimer(pTimer);
 
         vRet = pRetObj;
 
         return TRUE;
 }
 
 FX_BOOL app::clearTimeOut(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         CJS_Context* pContext = (CJS_Context*)cc;
         ASSERT(pContext != NULL);
         CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         ASSERT(pRuntime != NULL);
 
         if (params.size() != 1)
         {
                 sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSPARAMERROR);
                 return FALSE;
         }
 
         if (params[0].GetType() == VT_fxobject)
         {
-                JSFXObject pObj = (JSFXObject)params[0];
+                JSFXObject pObj = params[0].ToV8Object();
                 {
                         if (JS_GetObjDefnID(pObj) == JS_GetObjDefnID(*pRuntime, L"TimerObj"))
                         {
-                                if (CJS_Object* pJSObj = (CJS_Object*)params[0])
+                                if (CJS_Object* pJSObj = params[0].ToCJSObject())
                                 {
                                         if (TimerObj* pTimerObj = (TimerObj*)pJSObj->GetEmbedObject())
                                         {
                                                 if (CJS_Timer* pTimer = pTimerObj->GetTimer())
                                                 {
                                                         pTimer->KillJSTimer();
 
                                                         for (int i=0,sz=m_aTimer.GetSize(); i<sz; i++)
                                                         {
                                                                 if (m_aTimer[i] == pTimer)
@@ skipping 23 matching lines @@
         ASSERT(pRuntime != NULL);
 
         if (params.size() != 1)
         {
                 sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSPARAMERROR);
                 return FALSE;
         }
 
         if (params[0].GetType() == VT_fxobject)
         {
-                JSFXObject pObj = (JSFXObject)params[0];
+                JSFXObject pObj = params[0].ToV8Object();
                 {
                         if (JS_GetObjDefnID(pObj) == JS_GetObjDefnID(*pRuntime, L"TimerObj"))
                         {
-                                if (CJS_Object* pJSObj = (CJS_Object*)params[0])
+                                if (CJS_Object* pJSObj = params[0].ToCJSObject())
                                 {
                                         if (TimerObj* pTimerObj = (TimerObj*)pJSObj->GetEmbedObject())
                                         {
                                                 if (CJS_Timer* pTimer = pTimerObj->GetTimer())
                                                 {
                                                         pTimer->KillJSTimer();
 
                                                         for (int i=0,sz=m_aTimer.GetSize(); i<sz; i++)
                                                         {
                                                                 if (m_aTimer[i] == pTimer)
@@ skipping 63 matching lines @@
 
 FX_BOOL app::goForward(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
   // Not supported.
   return TRUE;
 }
 
 FX_BOOL app::mailMsg(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         CJS_Context* pContext = (CJS_Context*)cc;
-        ASSERT(pContext != NULL);
-
         v8::Isolate* isolate = GetIsolate(cc);
 
         FX_BOOL bUI = TRUE;
         CFX_WideString cTo = L"";
         CFX_WideString cCc = L"";
         CFX_WideString cBcc = L"";
         CFX_WideString cSubject = L"";
         CFX_WideString cMsg = L"";
-        if(params.size() < 2)
+
+        if (params.size() < 1)
                 return FALSE;
 
-        bUI = params.size()>=1?(int)params[0]:TRUE;
-        cTo = params.size()>=2?(const wchar_t*)(FX_LPCWSTR)params[1].operator CFX_WideString():L"";
-        cCc = params.size()>=3?(const wchar_t*)(FX_LPCWSTR)params[2].operator CFX_WideString():L"";
-        cBcc = params.size()>=4?(const wchar_t*)(FX_LPCWSTR)params[3].operator CFX_WideString():L"";
-        cSubject = params.size()>=5?(const wchar_t*)(FX_LPCWSTR)params[4].operator CFX_WideString():L"";
-        cMsg = params.size()>=6?(const wchar_t*)(FX_LPCWSTR)params[5].operator CFX_WideString():L"";
-
-
         if (params[0].GetType() == VT_object)
         {
-                JSObject pObj = (JSObject)params[0];
+                JSObject pObj = params[0].ToV8Object();
 
-                v8::Handle<v8::Value> pValue = JS_GetObjectElement(isolate,pObj, L"bUI");
-                        bUI = (int)CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue));
+                v8::Handle<v8::Value> pValue = JS_GetObjectElement(isolate, pObj, L"bUI");
+                bUI = CJS_Value(isolate, pValue, GET_VALUE_TYPE(pValue)).ToBool();
 
                 pValue = JS_GetObjectElement(isolate, pObj, L"cTo");
-                        cTo = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
+                cTo = CJS_Value(isolate, pValue, GET_VALUE_TYPE(pValue)).ToCFXWideString();
 
-                pValue = JS_GetObjectElement(isolate,pObj, L"cCc");
-                        cCc = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
+                pValue = JS_GetObjectElement(isolate, pObj, L"cCc");
+                cCc = CJS_Value(isolate, pValue, GET_VALUE_TYPE(pValue)).ToCFXWideString();
 
-                pValue = JS_GetObjectElement(isolate,pObj, L"cBcc");
-                        cBcc = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
+                pValue = JS_GetObjectElement(isolate, pObj, L"cBcc");
+                cBcc = CJS_Value(isolate, pValue, GET_VALUE_TYPE(pValue)).ToCFXWideString();
 
-                pValue = JS_GetObjectElement(isolate,pObj, L"cSubject");
-                        cSubject = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
+                pValue = JS_GetObjectElement(isolate, pObj, L"cSubject");
+                cSubject = CJS_Value(isolate, pValue, GET_VALUE_TYPE(pValue)).ToCFXWideString();
 
-                pValue = JS_GetObjectElement(isolate,pObj, L"cMsg");
-                        cMsg = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
+                pValue = JS_GetObjectElement(isolate, pObj, L"cMsg");
+                cMsg = CJS_Value(isolate, pValue, GET_VALUE_TYPE(pValue)).ToCFXWideString();
+        } else {
+                if (params.size() < 2)
+                        return FALSE;
+
+                bUI = params[0].ToBool();
+                cTo = params[1].ToCFXWideString();
+
+                if (params.size() >= 3)
+                        cCc = params[2].ToCFXWideString();
+                if (params.size() >= 4)
+                        cBcc = params[3].ToCFXWideString();
+                if (params.size() >= 5)
+                        cSubject = params[4].ToCFXWideString();
+                if (params.size() >= 6)
+                        cMsg = params[5].ToCFXWideString();
         }
 
-
-
         CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         ASSERT(pRuntime != NULL);
 
         CPDFDoc_Environment* pApp = pContext->GetReaderApp();
         ASSERT(pApp != NULL);
 
         pRuntime->BeginBlock();
         pApp->JS_docmailForm(NULL, 0, bUI, cTo.c_str(), cSubject.c_str(), cCc.c_str(), cBcc.c_str(), cMsg.c_str());
-        ///////////////////////////////////////////////////////////////////////////////////////////////
         pRuntime->EndBlock();
 
-        //return bRet;
         return FALSE;
 }
 
 FX_BOOL app::launchURL(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
   // Unsafe, not supported.
   return TRUE;
 }
 
 FX_BOOL app::runtimeHighlight(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
@@ skipping 69 matching lines @@
         CFX_WideString swLabel = L"";
         CFX_WideString swTitle = L"PDF";
         CFX_WideString swDefault = L"";
         bool bPassWord = false;
 
         v8::Isolate* isolate = GetIsolate(cc);
 
         int iLength = params.size();
         if (iLength > 0 && params[0].GetType() == VT_object)
         {
-                JSObject pObj = (JSObject )params[0];
+                JSObject pObj = params[0].ToV8Object();
                 v8::Handle<v8::Value> pValue = JS_GetObjectElement(isolate,pObj,L"cQuestion");
-                swQuestion = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
+                swQuestion = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).ToCFXWideString();
 
                 pValue = JS_GetObjectElement(isolate,pObj,L"cTitle");
-                swTitle = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
+                swTitle = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).ToCFXWideString();
 
                 pValue = JS_GetObjectElement(isolate,pObj,L"cDefault");
-                swDefault = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
+                swDefault = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).ToCFXWideString();
 
                 pValue = JS_GetObjectElement(isolate,pObj,L"cLabel");
-                swLabel = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
+                swLabel = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).ToCFXWideString();
 
                 pValue = JS_GetObjectElement(isolate,pObj,L"bPassword");
-                bPassWord = (bool)CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue));
+                bPassWord = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).ToBool();
         }
         else
         {
                 switch(iLength)
                 {
                 case 5:
-                        swLabel = params[4];
+                        swLabel = params[4].ToCFXWideString();
                         // FALLTHROUGH
                 case 4:
-                        bPassWord = params[3];
+                        bPassWord = params[3].ToBool();
                         // FALLTHROUGH
                 case 3:
-                        swDefault = params[2];
+                        swDefault = params[2].ToCFXWideString();
                         // FALLTHROUGH
                 case 2:
-                        swTitle = params[1];
+                        swTitle = params[1].ToCFXWideString();
                         // FALLTHROUGH
                 case 1:
-                        swQuestion = params[0];
+                        swQuestion = params[0].ToCFXWideString();
                         // FALLTHROUGH
                 default:
                         break;
                 }
         }
 
         CJS_Context* pContext = (CJS_Context *)cc;
         ASSERT(pContext != NULL);
 
         CPDFDoc_Environment* pApp = pContext->GetReaderApp();
@@ skipping 22 matching lines @@
 
 FX_BOOL app::media(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         return FALSE;
 }
 
 FX_BOOL app::execDialog(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         return TRUE;
 }