Wrap messages implementation in a function.

Wrap messages implementation in a function.

R=jkummerow@chromium.org

Committed: https://crrev.com/77e37028c6cad6cc31de975d392e2f820b608ec4
Cr-Commit-Position: refs/heads/master@{#28074}

[Yang, 2015-04-23 11:48:12]

The changes to messages.js are a bit ugly, but will be resolved eventually when
I replace the jsbuiltins object.

[Jakob Kummerow, 2015-04-23 12:09:21]

LGTM with nits.

https://codereview.chromium.org/1106633002/diff/1/src/messages.js
File src/messages.js (right):

https://codereview.chromium.org/1106633002/diff/1/src/messages.js#newcode1024
src/messages.js:1024: if (IS_FUNCTION(GlobalError.prepareStackTrace) &&
!formatting_custom_stack_trace) {
nit: 80col

https://codereview.chromium.org/1106633002/diff/1/src/messages.js#newcode1303
src/messages.js:1303: //Boilerplate for exceptions for stack overflows. Used
from
nit: space after //

https://codereview.chromium.org/1106633002/diff/1/tools/js2c.py
File tools/js2c.py (right):

https://codereview.chromium.org/1106633002/diff/1/tools/js2c.py#newcode72
tools/js2c.py:72: INVALID_ERROR_MESSAGE_PATTERN =
re.compile(r'Make(?!Generic)\w*Error\(([kA-Z]\w+)')
nit: 80col

Pro tip: break after '(', then you don't need any trailing backslashes. I.e.: 

INVALID_ERROR_MESSAGE_PATTERN = re.compile(
    r'Make(?!Generic)\w*Error\(([kA-Z]\w+)')

[Yang, 2015-04-24 10:25:41]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-04-24 10:25:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1106633002/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2015-04-24 10:25:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1106633002/20001

[commit-bot: I haz the power, 2015-04-24 11:01:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-24 11:01:54]

Try jobs failed on following builders:
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/4248)

[Yang, 2015-04-24 12:53:39]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-04-24 12:53:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1106633002/20001

[commit-bot: I haz the power, 2015-04-24 13:30:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-24 13:30:22]

Try jobs failed on following builders:
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/4263)

[Yang, 2015-04-27 12:01:25]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-04-27 12:01:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1106633002/#ps40001
(title: "fix and rebase")

[commit-bot: I haz the power, 2015-04-27 12:01:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1106633002/40001

[commit-bot: I haz the power, 2015-04-27 12:34:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-27 12:34:15]

Patchset 3 (id:??) landed as
https://crrev.com/77e37028c6cad6cc31de975d392e2f820b608ec4
Cr-Commit-Position: refs/heads/master@{#28074}