src/messages.cc - Issue 1106633002: Wrap messages implementation in a function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.cc

Issue 1106633002: Wrap messages implementation in a function. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@messages_5

Patch Set: fix and rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/messages.cc

diff --git a/src/messages.cc b/src/messages.cc

index bdfc5180b408804e907528c5e724ec96418d9430..1c07854fb55bb9355414527f50855670c5a292a6 100644

--- a/src/messages.cc

+++ b/src/messages.cc

@@ -131,7 +131,7 @@ Handle<String> MessageHandler::GetMessage(Isolate* isolate,

Handle<Object> data) {

Factory* factory = isolate->factory();

Handle<String> fmt_str =

- factory->InternalizeOneByteString(STATIC_CHAR_VECTOR("FormatMessage"));

+ factory->InternalizeOneByteString(STATIC_CHAR_VECTOR("$formatMessage"));

Handle<JSFunction> fun = Handle<JSFunction>::cast(Object::GetProperty(

isolate->js_builtins_object(), fmt_str).ToHandleChecked());

Handle<JSMessageObject> message = Handle<JSMessageObject>::cast(data);

« no previous file with comments | « src/heap/heap.h ('k') | src/messages.js » ('j') | no next file with comments »