Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 110663007: PNaCl: Enable testing of computed gotos, including GCC torture tests (Closed)

Created:
7 years ago by Mark Seaborn
Modified:
6 years, 11 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

PNaCl: Enable testing of computed gotos, including GCC torture tests BUG=https://code.google.com/p/nativeclient/issues/detail?id=3695 TEST=toolchain trybot Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12582

Patch Set 1 #

Patch Set 2 : Retry upload #

Patch Set 3 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M pnacl/build.sh View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/computed_gotos/nacl.scons View 1 2 1 chunk +8 lines, -5 lines 0 comments Download
M tools/toolchain_tester/extra_flags_pnacl.txt View 1 2 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
6 years, 11 months ago (2014-01-07 13:44:11 UTC) #1
Derek Schuff
lgtm
6 years, 11 months ago (2014-01-07 16:47:31 UTC) #2
Mark Seaborn
6 years, 11 months ago (2014-01-07 16:51:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r12582 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698