tests/computed_gotos/nacl.scons - Issue 110663007: PNaCl: Enable testing of computed gotos, including GCC torture tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/computed_gotos/nacl.scons

Issue 110663007: PNaCl: Enable testing of computed gotos, including GCC torture tests (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Update comment Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/computed_gotos/nacl.scons

diff --git a/tests/computed_gotos/nacl.scons b/tests/computed_gotos/nacl.scons

index adf0b483ed25c72054f5bee7bded73b55abc648d..6bd8ff6311776a11b0689e45535857d25548ea9c 100644

--- a/tests/computed_gotos/nacl.scons

+++ b/tests/computed_gotos/nacl.scons

@@ -5,11 +5,14 @@

Import('env')

-if not env.AllowNonStableBitcode():

- Return()

-if env.Bit('bitcode'):

- # Computed gotos are currently not allowed by PNaCl's bitcode ABI.

- env.Append(LINKFLAGS=['--pnacl-disable-abi-check'])

+if env['TOOLCHAIN_FEATURE_VERSION'] < 4:

+ # In old versions of the PNaCl toolchain, computed gotos are left as

+ # "indirectbr" and "blockaddress", which are not allowed by PNaCl's

+ # stable ABI.

+ if not env.AllowNonStableBitcode():

+ Return()

+ if env.Bit('bitcode'):

+ env.Append(LINKFLAGS=['--pnacl-disable-abi-check'])

# We are testing a GNU C extension which is disallowed by "-pedantic" mode.

env.FilterOut(CCFLAGS=['-pedantic'])

« no previous file with comments | « pnacl/build.sh ('k') | tools/toolchain_tester/extra_flags_pnacl.txt » ('j') | no next file with comments »